Uncaught CKEditorError: Cannot read properties of undefined (reading 'pencil')
Read more: https://ckeditor.com/docs/ckeditor5/latest/support/error-codes.html#error-Cannot read properties of undefined (reading 'pencil')

Steps to reproduce

  • Find a form using CKEditor configured with entity embed.
  • Embed a new entity or edit content with an existing embed.
  • Click the embedded entity in the editor

Expected results

The tooltip displays with buttons for edit, Link entity embed, and Edit the embedded entity, eg.

Screenshot of tooltip working correctly

Actual results

Proposed resolution

The tooltip does not show up. There is no option to edit the embedded entity.
The upgraded CKEditor5 library included with Drupal 10.6.x/11.2.x/11.3.x causes entity_embed to lose functionality.

See upstream issue

#3531672: Drupal 10.5/11.2 Compatibility (tooltip broken, cannot edit embedded entities)
and while we're at it, might as well patch for this entity_embed bug as well.
#3086162: Remove alt and title attributes from Entity Embed container div

Steps to reproduce

Install or upgrade to one of the mentioned WxT+ Drupal core versions.

Proposed resolution

Review and merge this wxt PR into 6.2.x prior to creating 6.3.x and then cherry-pick the fix back over to 5.6.x.

Remaining tasks

See wxt 6.2.x PR

User interface changes

Restore lost functionality, contextual edit links in the wysiwyg editor ckeditor5 being the most important.

API changes

Updates to the entity_embed module via a fix/patch.

Data model changes

N/A

Comments

joseph.olstad created an issue. See original summary.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

I pinged the maintainers of entity_embed in Slack. davereid , one of the maintainers is looking into this upstream, with that said, I'll still push up a PR in a bit.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Related issues: +#3086162: Remove alt and title attributes from Entity Embed container div, +#3531672: Drupal 10.5/11.2 Compatibility (tooltip broken, cannot edit embedded entities)
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Issue summary: View changes
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Assigned: joseph.olstad » smulvih2
Issue summary: View changes
Status: Active » Needs review

  • smulvih2 committed 9bf7bf24 on 5.6.x 
    fix: #3574105 - WxT 6.2.x / 6.3.x and 5.6.x, entity_embed critical fix

  • joseph.olstad authored 25671515 on 6.2.x 
    feat: #3574105 entity_embed for wxt 5.6.x, wxt 6.2.x and wxt 6.3.x...
smulvih2’s picture

smulvih2
Location Canada 🍁
commented
Status: Needs review » Fixed

I tested this and it works as expected! I pushed this to both 5.6.x and 6.2.x.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

smulvih2’s picture

smulvih2
Location Canada 🍁
commented
Title: entity_embed for wxt 5.6.x, wxt 6.2.x and wxt 6.3.x » Fix missing icons for entity_embed [5.6.x, 6.2.x]
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Assigned: smulvih2 » Unassigned

Thanks  @smulvih2

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.