Problem/Motivation

\Drupal\system\SystemManager::$menuItems was added in #1987814: Convert system_admin_menu_block_page() to a new style controller for use in SystemManager::getAdminBlock and later refactored in #2301317: MenuLinkNG part4: Conversion. I would think we can probably just remove this without deprecating it.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3573903

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mstrelan created an issue. See original summary.

ishani patel’s picture

ishani patel commented
Assigned: Unassigned » ishani patel

ishani patel opened merge request !14785

ishani patel’s picture

ishani patel commented
Assigned: ishani patel » Unassigned
Status: Active » Needs review

@mstrelan, I've raised MR.
Please check and review.

Thank you!!

mstrelan’s picture

mstrelan commented

This looks good. I note you have over 50 credits on issues, ideally we like to reserve the Novice issues for new contributors to get used to contributing.

Going to leave the status as Needs Review in case anyone else thinks we might need to deprecate this property.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Think we are probably good to skip deprecations since nothing is calling it

And to echo what @mstelan mentioned if you have over 2 pages of posts then definitely can avoid novice issues.

Thanks.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Title: Remove unused SystemManger::$menuItems property » Remove unused SystemManager::$menuItems property

  • longwave committed 7adf0a6a on 11.x 
    refactor: #3573903 Remove unused SystemManager::$menuItems property

By...

  • longwave committed 549c6fb9 on main 
    refactor: #3573903 Remove unused SystemManager::$menuItems property

By...
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 549c6fb943a to main and 7adf0a6afa8 to 11.x. Thanks!

Doesn't seem worth backporting further than this, but good to clean it up all the same.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

longwave closed merge request !14785

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.