Problem/Motivation

While working on the removal of Migrate Drupal I found two tests in the Migrate module that are relying on Migrate Drupal.
See #3572280-3: Remove Migrate Drupal

Steps to reproduce

Proposed resolution

Add a test module to supply a version of the EmptySource source plugin. Use in
Move StubTestTrait to the Migrate module.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3573895

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone opened merge request !14779

quietone’s picture

quietone commented

I don't get where these additions to the phpstan baseline about migrate_drupal_ui are coming from. If I generate the phpstan baseline on main I get the same additions as in this MR. The baseline on HEAD seems out of date?

quietone’s picture

quietone commented
Status: Active » Needs review

What ever was wrong was local, I rebuilt that ddev instance and this is now working as expected.

godotislate’s picture

godotislate
he/him
commented

One question on the MR about a deprecation message about the EmptySource plugin that's being added here.

godotislate’s picture

godotislate
he/him
commented
Status: Needs review » Needs work

Some small things like adding type declarations, but it's close.

quietone’s picture

quietone commented
Status: Needs work » Needs review

OK, time for another review.

godotislate’s picture

godotislate
he/him
commented
Status: Needs review » Reviewed & tested by the community

I think this looks fine now.

  • catch committed d1d97d76 on main 
    task: #3573895 Fix test integrations using migrate_drupal

By: quietone...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main, thanks!

This doesn't cherry-pick cleanly to 11.x due to phpstan, happy to backport if we think it's worth it though.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

catch closed merge request !14779

quietone reopened merge request !14779

quietone’s picture

quietone commented
Status: Fixed » Patch (to be ported)

Since this was an oversight and should have been done before before deprecating Migrate Drupal I support a backport. I have change the MR to 11.x and tests are passing. There were no conflicts, just had to rebuild the phpstan baseline.

  • catch committed 3cbd1934 on 11.x 
    task: #3573895 Fix test integrations using migrate_drupal

By: quietone...
catch’s picture

catch
he/him
Primary language English
commented
Version: main » 11.x-dev
Status: Patch (to be ported) » Fixed

Backport looks good. Committed/pushed to 11.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

catch closed merge request !14779

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.