Problem/Motivation

I have a disabled theme that is having vite configuration in it's info yml. When getViteSettingFromExtensionDefinition function is trying to find extensions with vite configuration inside it does not catch the exception if the theme is not installed.

👉 This might occur especially if you are having a disabled starterkit theme

Steps to reproduce

Add following lines to an uninstalled theme:

vite:
  enabled: true
  enableInAllLibraries: true
  enableInAllComponents: true

Proposed resolution

Add try/catch wrapper to catch uninstalled theme exception.

Issue fork vite-3573302

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

yannickoo created an issue. See original summary.

yannickoo’s picture

Status: Active » Needs review
yannickoo’s picture

Issue summary: View changes

yannickoo’s picture

Status: Needs review » Closed (won't fix)

It seems like this is not needed anymore, I was explicitly calling a library from an uninstalled theme 😇

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

yannickoo’s picture

Status: Closed (won't fix) » Active

Opening this again since I experience this error if I have an uninstalled theme that has Vite configuration.

wotnak made their first commit to this issue’s fork.

  • wotnak committed 62403e43 on 1.x authored by yannickoo
    fix: #3573302 Don't resolve Vite settings for uninstalled extensions
    
    By...
wotnak’s picture

Status: Active » Fixed

Fixed in 1.5.4.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

yannickoo’s picture

Thanks @wotnak!