crm_simpsons recipe fails to install when crm is not already installed

Recipe install is still failing.

In FieldStorageConfigStorage.php line 167:

  Unable to determine class for field type 'comment' found in the 'field.storage.0' configuration


In DiscoveryTrait.php line 53:

  The "comment" plugin does not exist. Valid plugin IDs for Drupal\Core\Field\FieldTypePluginManager are: address, address_country, address_zone, crm_relationship_statistics, datetime, name, primary_entity_refer
  ence, telephone, boolean, changed, created, decimal, email, entity_reference, float, integer, language, map, password, string, string_long, timestamp, uri, uuid


Failed to run drush site:install ../recipes/crm_simpsons: exit status 1

Not at my computer, but I followed the steps to reproduce with ddev drush site:install -y ../recipes/crm_simpsons

ddev composer config minimum-stability dev causes ddev composer require drupal/crm drush/drush to install the latest release of stability dev or higher. At the time of writing this comment, that is 1.0.0-beta4.

What @jcandan is encountering has already been fixed in the 1.0.x branch, but no release has yet been made containing that fix. I verified this by:

1. Reproducing the error following the steps @jcandan provided (noting that beta4 was installed); and
2. Failing to reprode the error via ddev composer require drupal/crm:dev-1.0.x drush/drush, which requires the latest code from the 1.0.x branch (colloquially referred to as the "dev branch")

The change in scope to an already fixed issue has made this issue too confusing to follow. I'm going to revert the issue title and description then follow up shortly on the FieldStorageConfigStorage error, which is related to the original scope.

Per Claude:

Here's the problem: the recipe's config: import: crm: '*' imports all config provided by the crm module, including optional config that depends on the comment module. The strict: false setting controls
whether existing config causes errors — it does not skip config with unmet module dependencies.

Running the install again, I now get the error:

In FieldConfig.php line 318:                                                                                                                         
                                                                                                                                                                                                       
    Attempted to create, modify or delete an instance of field with name comment_body on entity type comment when the field storage does not exist.

Claude:

This config depends on field.storage.comment.comment_body, which is provided by the comment module's default config. But it also depends on the text module (for the text_long field type). The comment
module itself depends on text, but the recipe may be importing this config before the comment module's own field storage is fully set up.

The fix is to also install text in the recipe so the field type is available

The fix required three changes to recipe.yml:

1. text added to install — provides the text_long field type
2. comment added to install — provides the comment field type
3. comment: '*' added to config: import — ensures field.storage.comment.comment_body is created before the crm module's config references it

I verified the fix, which is in https://git.drupalcode.org/project/crm/-/merge_requests/199

This makes it possible to apply the recipe using ddev drush site:install -y ../recipes/crm_simpsons (though it results in a pretty barren install as the recipe takes the place of the default "standard" recipe, but at least it doesn't error).

An alternative approach would be for the recipe to only apply the config it strictly needs.

For completeness...

This is not working against 1.0.x:

1. git clone git@git.drupal.org:project/crm.git simpsons4
2. cd simpsons4
3. ddev config --project-type=drupal --docroot=web --php-version=8.4 --corepack-enable --project-name=simpsons4
4. ddev add-on get ddev/ddev-drupal-contrib
5. ddev start
6. ddev poser
7. ddev symlink-project
8. ddev drush site:install ../recipes/crm_simpsons -y

ddev drush site:install ../recipes/crm_simpsons -y
 You are about to:
 * DROP all tables in your 'db' database.

 // Do you want to continue?: yes.

 [notice] Starting Drupal installation. This takes a while.
 [notice] Performed install task: install_select_language
 [notice] Performed install task: install_select_profile
 [notice] Performed install task: install_load_profile
 [notice] Performed install task: install_verify_requirements
 [notice] Performed install task: install_verify_database_ready
 [notice] Performed install task: install_base_system
 [notice] Performed install task: install_bootstrap_full
 [notice] Performed install task: install_recipe_required_modules

In FieldStorageConfigStorage.php line 167:

  Unable to determine class for field type 'comment' found in the 'field.storage.0' configuration


In DiscoveryTrait.php line 53:

  The "comment" plugin does not exist. Valid plugin IDs for Drupal\Core\Field\FieldTypePluginManager are: address, address_country, address_zone, crm_relationship_statistics, datetime, file, file_uri, image, nam
  e, primary_entity_reference, telephone, boolean, changed, created, decimal, email, entity_reference, float, integer, language, map, password, string, string_long, timestamp, uri, uuid


Failed to run drush site:install ../recipes/crm_simpsons -y: exit status 1

The MR referenced in my previous comment addresses this.

I don't think there is evidence here of a problem with recipes in general. Recipes should be able to be installed via drush site:install without erroring.

Comments would only be a dependency of the sample data recipe, right? Not sure I see any problem with that.

The (theoretical) approach of only importing optional config that the recipe actually needs would resolve this issue without making the recipe dependent on comments. I have no objection to that approach.