Problem/Motivation

Many of our bug fixes have made it into recent releases of wet-boew that pertain to jQuery 4 support required for Drupal 11.

This upgrade also includes known fixes for bugs reported in #3566502: Upgrade wet-boew from 4.0.85 to 4.0.94.1

It's time to upgrade.

Also, probably should upgrade gcweb to 18.3.0 while we're at it.

Here's the first related PR, it's for composer-extdeps
We'll need another PR for wxt_library to update the composer.json.
And a wxt PR since twitter.svg was dropped in favour of x.svg

Steps to reproduce

Install wxt 6.2.x

Proposed resolution

Upgrade wet-boew to 4.0.95 and gcweb to 18.3.0

Remaining tasks

  1. Merge composer-extdeps PR
  2. Merge wxt_library PR
  3. Merge wxt PR
  4. Tag wxt_library
  5. Pull latest wxt_library tag into wxt.
  6. Run ci/cd
  7. Prepare wxt 6.2.x/6.3.x release

User interface changes

Should be minor, mostly bug fixes

API changes

Minor js/front end changes, mostly bug fixes.

Data model changes

N/A

CommentFileSizeAuthor
#11 wet-boew-gcweb-upgrade-issue.jpg201.57 KBsmulvih2

Comments

joseph.olstad created an issue. See original summary.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Issue summary: View changes
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Issue summary: View changes
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Issue summary: View changes

Tested this locally, so far the only issue I've noticed is that the twitter.svg was renamed and updated to x.svg. I had to update something on my side. I'll created a wxt PR for this and updated the issue summary.

Looks good, no js exceptions, works well.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Issue summary: View changes
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Assigned: joseph.olstad » smulvih2
Status: Active » Needs review
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Issue summary: View changes

  • joseph.olstad authored 2201e807 on 6.2.x 
    Update cke5-theme-gcweb.css

fix: #3572922 Upgrade wet-boew to 4.0.95...
smulvih2’s picture

smulvih2
Location Canada 🍁
commented
Status: Needs review » Fixed

@joseph good call on the update of wet-boew, and especially gcweb, this was long overdue! I tested this locally with migrated content and everything looks good, and tests are passing. This has been merged with 6.2.x and pushed to GitHub/Drupalcode.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

smulvih2’s picture

smulvih2
Location Canada 🍁
commented
Status: Fixed » Needs work
StatusFileSize
new wet-boew-gcweb-upgrade-issue.jpg201.57 KB

Tested the migrated content and noticed an issue with this update, specifically an issue with the footer styles, see image below.

wet-boew gcweb upgrade issue

smulvih2’s picture

smulvih2
Location Canada 🍁
commented
Status: Needs work » Fixed

Ended up being pretty easy fix, .landscape was replaced with .gc-main-footer, and .brand was replaced with .gc-sub-footer. Pushed the fix to wxt_bootstrap for this.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

Ya I had a page twig in my subtheme that I had to doctor up in the same manner, I looked at your commit in wxt_bootstrap , made the same changes exactly where you made them, had to add one tiny directive to my css and then it was fixed.

Perhaps a note should be added to the release which BTW, in the release notes I noticed that you're not using the freebie issue link that is , square bracket, hash symbol , issue number close square bracket.

ping me a DM and I can show you this quickly.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.