Problem/Motivation

Drupal\Core\Path\Plugin\Validation\Constraint\UniquePathAliasConstraint predates the path_alias module. As part of the effort to make path aliases optional (#3096092: Make "path_alias" module optional), we should move this constraint where it belongs.

Proposed resolution

Move that constraint to the path_alias module.

Remaining tasks

Review.

CommentFileSizeAuthor
#8 3572667-nr-bot_vwkz3cny.txt430 bytesneeds-review-queue-bot

Issue fork drupal-3572667

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

amateescu created an issue. See original summary.

amateescu opened merge request !14718

amateescu’s picture

amateescu commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Issue tags: +Needs Review Queue Initiative

Can you regenerate the baseline please

sivaji_ganesh_jojodae made their first commit to this issue’s fork.

sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented
Status: Needs work » Needs review

Updated phpstan baseline and rebased the branch.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Seems like a good rebase. Since it had been a month probably fair to pick up too

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Reviewed & tested by the community » Needs work
StatusFileSize
new 3572667-nr-bot_vwkz3cny.txt430 bytes

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

amateescu’s picture

amateescu commented
Status: Needs work » Reviewed & tested by the community
godotislate’s picture

godotislate
he/him
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs change record

Constraint plugin classes aren't considered API and don't have a BC promise, but it's less clear about constraint validators. Presumably they're not API either. But since domain_path extends UniquePathAliasConstraintValidator.php (https://git.drupalcode.org/project/domain_path/-/blob/3.x/src/Plugin/Val...), and domain_unique_path as well: https://git.drupalcode.org/project/domain_unique_path_alias/-/blob/1.x/s..., I think we can provide some BC using moved_classes: https://www.drupal.org/node/3509577. And add a CR for the move as well.

amateescu’s picture

amateescu commented
Status: Needs work » Reviewed & tested by the community
Issue tags: -Needs change record

Added a CR and used moved_classes, thanks for the review :)