Problem/Motivation

This came up in #3568006: Surface person fields on the mapped user:

\Drupal\crm\Form\UserContactMappingSettingsForm::INTERNAL_FIELDS - provide a way for modules to declare additional fields as excluded

Proposed resolution

Add alter hook or event, to allow other modules to extend the default list of internal fields.

Issue fork crm-3572590

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

svendecabooter created an issue. See original summary.

svendecabooter’s picture

svendecabooter
he/him
Primary language Dutch
Location Gent
commented
Category: Task » Feature request

svendecabooter opened merge request !203

svendecabooter’s picture

svendecabooter
he/him
Primary language Dutch
Location Gent
commented
Status: Active » Needs review

bluegeek9 made their first commit to this issue’s fork.

bluegeek9 changed the visibility of the branch 1.0.x to hidden.

bluegeek9’s picture

bluegeek9 commented
Status: Needs review » Needs work
Related issues: +#3573906: "Comment" field mapping exposes unexpected comment settings and errors

I believe events are preferred over hooks for new features, but I am not aware of the details of when to use one over the other.

I added something for field type to handle comment fields, #3573906: "Comment" field mapping exposes unexpected comment settings and errors.

Can we switch to an event, and handle field types too.

jdleonard’s picture

jdleonard
he/him
Primary language English
Location Austin, Texas
commented

I was also not aware of when to use a hook vs. an event. Here's Gemini's analysis: https://gemini.google.com/share/2af970d8ff69

It sounds like Gemini would advocate for a hook in this case due to the data being manipulated being simple, but I only offer that as an input, not a recommendation.

bluegeek9’s picture

bluegeek9 commented
Assigned: Unassigned » bluegeek9
Status: Needs work » Active
bluegeek9’s picture

bluegeek9 commented
Assigned: bluegeek9 » Unassigned
Status: Active » Needs review
bluegeek9’s picture

bluegeek9 commented
Status: Needs review » Fixed
//www.flaticon.com/free-icons/thank-you Thank you for your contribution! Your continued support makes this project sustainable.
There are multiple ways to show appreciation for the work contributed to this project including:
  • Triage issues and adding more context to existing issues.
  • Flagging CRM as a favorite on the project page to help others discover it and show your support.
  • Review the Developer Docs for accuracy and clarity.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

bluegeek9 opened merge request !276

  • bluegeek9 committed 9357ba47 on 1.0.x 
    feat: #3572590 User field mapping: provide way to declare additional...

  • 80e1318f committed on 1.0.x 
    feat: #3572590 User field mapping: provide way to declare additional...