Problem/Motivation

Step 1) Merge this PR for drupalwxt composer-extdeps which up until this PR holds us to 5.65.8.
Step 2) Revert this commit: https://git.drupalcode.org/project/wxt/-/commit/417ae830f1b26e9
Step 3) Sip marguaritas.

#3531472: Drupal 10.5 / 11.2 incompatibility

Steps to reproduce

see 3531472

Proposed resolution

See problem/motivation section above.

would be nice also to pin the new minimum release version for ckeditor_codemirror to ^3.1.1 which would ensure everyone updating gets the fix but probably isn't necessary.

Remaining tasks

Make it so

User interface changes

avoids patching something that was already fixed/patched

Comments

joseph.olstad created an issue. See original summary.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Active » Needs review
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Assigned: smulvih2 » joseph.olstad
Status: Needs review » Active

Reviewing this now.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

Weird, I'm still seeing the blasted 5.65.8 after upgrading to ckeditor_codemirror

composer info codemirror/codemirror

name     : codemirror/codemirror
descrip. : 
keywords : 
versions : * v5.65.8
type     : drupal-library
homepage : 
source   : []  
dist     : [tar] https://registry.npmjs.org/codemirror/-/codemirror-5.65.8.tgz 
path     : /myproject/html/libraries/codemirror
names    : codemirror/codemirror

OK, figured this out

, PR is ready!

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Title: revert codemirror patch and pin ckeditor_codemirror to ^3.1.1 » revert codemirror patch and update composer-extdeps
Issue summary: View changes
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Assigned: joseph.olstad » smulvih2
Issue summary: View changes
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Active » Needs review
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Issue summary: View changes
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Issue summary: View changes
smulvih2’s picture

smulvih2
Location Canada 🍁
commented
Status: Needs review » Needs work

@joejoseph00 your PR replaces `5.68.8` with `5.65.21`, but I think we have to add the new version and keep the old version. WxT `5.6.x` currently uses `5.68.8` (https://github.com/drupalwxt/site-wxt/blob/e66a1dc6408dff8f63e9bcaefa69a93a33915d91/composer.lock#L194), and even if we update `5.6.x` to use the new version this could break builds. Best to add the new version and keep the old version for a period of time. Please update PR, thanks!

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs work » Needs review

fixed that, thanks for catching that, oops ya, it's good now.

smulvih2’s picture

smulvih2
Location Canada 🍁
commented
Status: Needs review » Fixed

This has been fixed.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Assigned: smulvih2 » Unassigned

Thanks  @smulvih2

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.