Problem/Motivation

The core patch from composer.json is not needed anymore because #3557014: PageDisplayVariant does not transmit cache metadata has been committed 🎉

Issue fork display_builder-3572086

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

yannickoo created an issue. See original summary.

yannickoo opened merge request !224

yannickoo’s picture

yannickoo
Location Berlin
commented
Status: Active » Needs review
pdureau’s picture

pdureau commented
Status: Needs review » Needs work

Indeed, the patch has been commited to Drupal 11.3 the 12 of January and Drupal 11.3.3-has been released 5 of February.

Do we need to also bump the version in composer.json display_builder.info.yml ? Currently it is 11.3 on both, do we put 11.3.3 instead?

pdureau’s picture

pdureau commented
Issue tags: +display_builder-1.0.0-beta3
yannickoo’s picture

yannickoo
Location Berlin
commented
Status: Needs work » Needs review

Updated the core version requirement, so back to Needs review 😎

pdureau’s picture

pdureau commented

Playwright is still testing with Drupal 11.3.2 and fails in pipeline, so i guess we need to wait a bit before merging.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

https://git.drupalcode.org/issue/display_builder-3572086/-/jobs/8398741

Drupal installed version: 11.3.2

While the MR wants to force it at 11.3.3

Maybe CI needs to be re-executed and will run on 11.3.3 or higher?

pdureau’s picture

pdureau commented

Maybe CI needs to be re-executed and will run on 11.3.3 or higher?

Ok I rebase so it will run the pipeline again.

pdureau’s picture

pdureau commented
Assigned: Unassigned » mogtofu33

it worked!

a.dmitriiev’s picture

a.dmitriiev commented
Status: Needs review » Reviewed & tested by the community

The pipeline is green now, the correct Drupal version is pulled and no patches to core anymore.

mogtofu33’s picture

mogtofu33 commented
Assigned: mogtofu33 » Unassigned
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • mogtofu33 committed 87b62770 on 1.0.x authored by yannickoo 
    fix: #3572086 Remove core patch that has been committed to 11.3

By:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.