Problem/Motivation

See #3488827: [meta] Tasks to remove Ban module

Steps to reproduce

Proposed resolution

Remaining tasks

  • The change record for this issue should include a link to recommendations page, https://www.drupal.org/node/3223395#s-ban. (For example, the CR for removing HAL)
  • Tag this issue 'Needs release note.'
  • Remove the extension ;-).
  • Update Update path tests as needed. See Writing Automated Update Tests for Drupal 8 (or later) for details.
  • Remove references from core/phpstan-baseline.neon.
  • Remove any spelling words specific to the extension from the dictionary
  • Add the extension to the relevant removed list, either DRUPAL_CORE_REMOVED_MODULE_LIST or DRUPAL_CORE_REMOVED_THEME_LIST, in system.install.
  • Check for references in @todo.
  • Handle migration tests.
    • In all the functional tests in migrate_drupal_ui make sure that Ban is not installed. Ban should also be removed from the methods getAvailablePaths() and moved to getMissingPaths() in the tests using those methods.

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

The Ban module has been removed from core, and can now be installed as a contrib module.

Issue fork drupal-3571886

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mstrelan created an issue. See original summary.

mstrelan opened merge request !14663

mstrelan’s picture

mstrelan commented
Status: Active » Needs work

There some other things in migration fixtures I'm not sure about like the blocked_ips table and some menu links with ip-blocking in the path.

andypost made their first commit to this issue’s fork.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Needs review

Added fixture like I did for history module removal

quietone’s picture

quietone commented
Issue summary: View changes

Trying to update the IS with the steps.

quietone’s picture

quietone commented
Issue tags: +Needs change record, +Needs release note
smustgrave’s picture

smustgrave commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs change record, -Needs release note

Very neat workaround @andypost

I followed the same CR and release notes for Contact

quietone’s picture

quietone commented
Issue tags: +12.0.0 release notes
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Needs work

We need to add ban to SystemRequirements::DRUPAL_CORE_REMOVED_MODULE_LIST.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Needs review

added and rebased

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Rebased LGTM.

  • longwave committed 6817f476 on main 
    task: #3571886 Remove Ban from core

By: mstrelan
By: andypost
By:...
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 6817f4764fe to main. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

longwave closed merge request !14663

catch’s picture

catch
he/him
Primary language English
commented

Just under 18 years since I first tried to remove it #228594: UMN Usability: split access rules into an optional module.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.