Problem/Motivation
Track the steps needed to remove extension Ban from core to contrib. See Remove a core module and move it to a contributed project of the deprecation policy.
The removal of extension Ban was approved in #1570102: [Policy] Deprecate Ban module.
Remaining tasks
- ✅ Create a child issue, 'Remove Ban from core'. #3571886: Remove Ban from core
- ✅ Deprecate the extension in the current minor development branch. If the next major branch is open, the extension can be removed via a separate patch (to avoid dependent patches), otherwise an issue should be opened to remove the extension once the next major branch is open.
- ✅ Open an issue, 'Ensure that Ban does not get special core treatment' in the packages.drupal.org issue queue to ensure that the composer namespace for the contributed project matches the core one after removal. This is to allocate the
drupal/BanComposer namespace to contrib extension rather than the core extension. - >✅ Manually test upgrading from the core extension to the contrib extension. There is an issue template available for this.
- ✅ Triage core issues for Ban in the core queue and move either to the contrib project or the relevant core component. Restore the status to what it was before it was postponed. Also, is the issue moved to contrib, then move any change record.
- ✅ Move all core documentation for Ban to the contrib project. Make issues in the contrib project to update or add links to the documentation on the project page.
- ✅ When the issue in https://www.drupal.org/project/project_composer is Fixed update the documentation with the new Composer command.
Comments
Comment #3
mstrelan commentedOpened #3571886: Remove Ban from core
Comment #4
quietone commentedComment #5
andypostAs the module removed
Comment #6
mstrelan commentedI think steps 4-7 are still to do.
Comment #7
mstrelan commentedStep 5 is done.
I found this for Step 6 if someone wants to move it https://www.drupal.org/docs/8/core/modules/ban/overview
Comment #8
andypostI attempted to change Guide for the module but it still displayed under core
https://www.drupal.org/node/2829604 is ok but old link still works https://www.drupal.org/docs/8/core/modules/ban
Comment #9
quietone commentedYes, moving documentation has a few steps and I am not sure about what permissions are needed.
I've add the docs to the contributed module documentation menu, updated the URL, and edited the overview to both not state it is a core module and remove related content directed to EOL Drupal 7. I then created an issue in the Ban project to update the Resources section of the project page. I think that covers step 6.
I think 7 is complete?
That leaves step 4, manual testing.
Comment #10
mstrelan commentedFor step 7 I wasn't sure what "update the documentation with the new Composer command" is referring to.
Comment #11
quietone commentedOh, I am not sure either! I think that is from years ago any maybe the project pages are updated with the correct commands? I set this to complete in the issue summary.
Comment #12
mstrelan commentedI opened #3575883: Test the upgrade path for Ban for step 4 and documented my testing. Please review.
Comment #13
quietone commentedComment #14
quietone commented@mstrelan, completely the manual testing, which was the last thing to do here.
Thanks!