Problem/Motivation

Split off from #3502975: Remove all legacy code related to authorize.php and FileTransfer. We're removing authorize.php and everything related to it. stable9 has a Twig template and some CSS styles for this. Unclear if we should bother removing it or not, given #3560200: [meta] Tasks to deprecate Stable 9. This issue is to sort it out.

Steps to reproduce

Proposed resolution

Remove dead template and styles from stable9 related to authorize.php.

Remaining tasks

  1. Land #3502975: Remove all legacy code related to authorize.php and FileTransfer and #3571595: Remove authorize.php related Twig and CSS from core
  2. Rebase this

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3571596

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

dww created an issue. See original summary.

dww’s picture

Status: Active » Needs review
Related issues: +#3571595: Remove authorize.php related Twig and CSS from core

Hah, core/tests/Drupal/KernelTests/Core/Theme/Stable9TemplateOverrideTest.php failed. That test makes it hard to keep this separate from #3571595: Remove authorize.php related Twig and CSS from core. Maybe we should merge them?

dww’s picture

Title: [12.x] Remove authorize.php related Twig and CSS from stable9 » [pp-2] [12.x] Remove authorize.php related Twig and CSS from stable9
Issue summary: View changes
Status: Needs review » Postponed

The bot was happy at #3571595, so maybe we only have to postpone this, not merge them. So long as that lands first, once we rebase here, it should pass.

catch’s picture

Status: Postponed » Active
dww’s picture

Title: [pp-2] [12.x] Remove authorize.php related Twig and CSS from stable9 » Remove authorize.php related Twig and CSS from stable9
Status: Active » Needs review

Rebased MR to latest main. I believe this is ready, but let's see what the bot thinks...

dcam’s picture

Status: Needs review » Reviewed & tested by the community

This is the last issue dealing with the removal of authorize.php, right? There's only one comment reference to authorize.php left in the code, https://git.drupalcode.org/project/drupal/-/blob/main/core/lib/Drupal/Co.... If you want to include that in the scope of this issue, then I'm cool with it.

Otherwise, this looks good to me. I couldn't find any lingering references to the template and CSS that's removed by this issue. I'll go ahead and set the status to RTBC, but if you want to include that comment edit just set the status back to NR and I'll come back to check it.

dww’s picture

Thanks for the review!

Nicely spotted for that last "authorize.php" reference. Seems bad scope to fix that here, so I opened another sibling issue and put the change in an MR over there: #3575873: Remove final authorize.php reference in comment. Credited @dcam at that contribution record.

Almost there... 😅

dww’s picture

Side note: a recent GitLab upgrade has caused all MR pipelines to run in the parent project for us subsystem maintainers, which makes it impossible for us to re-run failed jobs. 😬 That's what the noise for those comment-only commits was about. https://drupal.slack.com/archives/CGKLP028K/p1772056493144239 for the interested Slack user. Maybe #3547431: Change global settings for all GitLab projects: fork pipelines and merge trains will be the solution.

  • catch committed 4fb8791b on main
    task: #3571596 Remove authorize.php related Twig and CSS from stable9...
catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to main, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.