Problem/Motivation

Split off from #3502975: Remove all legacy code related to authorize.php and FileTransfer. Per @catch: "I think we should split the CSS/template changes out to their own issue anyway and discuss it there."

We're finally removing authorize.php and everything related to it. This issue is specifically for these bits:

  1. template_preprocess_authorize_report() from core/includes/theme.inc
  2. authorize_report from commonElements() in core/lib/Drupal/Core/Theme/ThemeCommonElements.php
  3. core/modules/system/templates/authorize-report.html.twig
  4. The Authorize.php styles section from core/modules/system/css/system.maintenance.css

Steps to reproduce

Proposed resolution

Remove it all.

Remaining tasks

Land #3502975: Remove all legacy code related to authorize.php and FileTransfer

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3571595

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dww created an issue. See original summary.

dww opened merge request !14642

dww’s picture

dww
we/he/they
commented
Status: Active » Needs review

MR is up. Bot is happy. Ready for review.

dww’s picture

dww
we/he/they
commented
Title: [12.x] Remove authorize.php related Twig and CSS from core » [pp-1] [12.x] Remove authorize.php related Twig and CSS from core
Issue summary: View changes
Status: Needs review » Postponed

I guess more accurately this needs to be postponed on #3502975: Remove all legacy code related to authorize.php and FileTransfer landing, first.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Title: [pp-1] [12.x] Remove authorize.php related Twig and CSS from core » [12.x] Remove authorize.php related Twig and CSS from core
Status: Postponed » Active

The other issue got in, so this can be unpostponed

dww’s picture

dww
we/he/they
commented
Title: [12.x] Remove authorize.php related Twig and CSS from core » Remove authorize.php related Twig and CSS from core
Status: Active » Needs review

Rebased the MR for latest main.

dcam’s picture

dcam commented

Should core/themes/stable9/templates/admin/authorize-report.html.twig be removed along with the rest? It is deprecated for removal in D12 too. I found it when I grepped for the preprocess function name and located the @see annotation on the template.

dww’s picture

dww
we/he/they
commented

See #3571596: Remove authorize.php related Twig and CSS from stable9

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

Thank you for letting me know.

I grepped Core for any lingering uses of or references to the removed template, preprocess function, CSS selectors, and anything with the string authorize[-_]report. The only remaining items are in stable9, which as noted will be handled in a separate issue. This looks good to me.

  • catch committed 03fc6bda on main 
    task: #3571595 Remove authorize.php related Twig and CSS from core

By:...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

catch closed merge request !14642

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.