Problem/Motivation

When both commerce_usps 2.x and commerce_ups 4.x are installed with configured and enabled shipping methods, commerce_ups cannot retrieve rates with an error "401 UnAuthorized". If the USPS shipping method is disabled, the UPS method works again.

It appears to be because of this section of code

    // When multiple shipping methods with the same API credentials
    // are configured the "stack" is overflowed with the OAuth callbacks which
    // leads to the failed request. We should remove those callback before
    // adding again to make it work properly.
    $this->stack->remove('oauth_before');
    $this->stack->remove('oauth_failure');
    $this->stack->push($middleware->onBefore(), 'oauth_before');
    $this->stack->push($middleware->onFailure(2), 'oauth_failure');

Steps to reproduce

Install both commerce_usps 2.x and commerce_ups 4.x
Configure a shipping method for both modules with at least one service.
Create a shipment on an order or go through checkout. You only see the USPS rate(s).

Proposed resolution

If I copy the code pattern from USPS USPSSdkFactory to the UPS UPSSdkFactory which has this in the same location

    $this->stack->push($middleware->onBefore());
    $this->stack->push($middleware->onFailure(2));

Then both function correctly.

It's unclear to me if this should be fixed in the UPS module or here so I created an issue in both.
This also might affect any other modules that use the OAuth middleware.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork commerce_usps-3571397

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

rhovland created an issue. See original summary.

rhovland’s picture

rhovland
he/him
Primary language English
Location Oregon
commented
Related issues: +#3571396: Incompatible with commerce_usps 2.x
trobey’s picture

trobey commented

commerce_usps 2.x has not been working for me. Commerce UPS already is enabled and is working. When I change the order of the two in shipping methods Commerce USPS works and Commerce UPS fails.

rhovland’s picture

rhovland
he/him
Primary language English
Location Oregon
commented

Ah yes that makes sense. UPS came after USPS in my shipping method list.

jsacksick’s picture

jsacksick commented

As suggested in the related issue, I think we should create a new stack, like the following, rather than adding to the existing / global one:

use GuzzleHttp\HandlerStack;
$stack = HandlerStack::create();

tbkot made their first commit to this issue’s fork.

tbkot opened merge request !12

  • tbkot committed 3f445055 on 2.x 
    fix: #3571397 Incompatible with commerce_ups 4.x

By: jsacksick
By:...
tbkot’s picture

tbkot commented
Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.