Problem/Motivation

There appear to be a low number of deprecations in Drupal/Components so scoping this to the whole folder

Steps to reproduce

Proposed resolution

Remove all deprecated code targeted for D12. Also uncomment new parameters and typehints per #3570920: [meta] Adjust parameters in interfaces.

Remaining tasks

Make sure tests pass

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3571052

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

smustgrave created an issue. See original summary.

smustgrave opened merge request !14774

smustgrave’s picture

smustgrave commented

Went ahead and addressed #3570920: [meta] Adjust parameters in interfaces for this folder. Still a very small MR.

smustgrave’s picture

smustgrave commented
Status: Active » Needs review
dcam’s picture

dcam commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Everything here looks good to me. I grepped core/lib/Drupal/Component/ for "deprecat" and only got back results related to the DeprecationHelper utility, the service container, and SimpleAnnotationReader.

I updated the IS to mention that we're also uncommenting the interface parameters and typehints.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Reviewed & tested by the community » Needs work

I think we should also be removing the

%The "(?:Drupal\\Core\\Layout\\LayoutPluginManagerInterface|Drupal\\Core\\Block\\BlockManager)::get(?:Sorted|Grouped)Definitions\(\)" method will require a new "string \$label_key" argument in the next major version of its interface "Drupal\\Component\\Plugin\\CategorizingPluginManagerInterface"%

entry from core/.deprecation-ignore.txt.

smustgrave’s picture

smustgrave commented
Status: Needs work » Reviewed & tested by the community

Thanks @mondrake forgot to start checking there. Since it was 1 line removed restoring to RTBC

catch made their first commit to this issue’s fork.

catch’s picture

catch
he/him
Primary language English
commented

Applied a couple of suggestions on the MR to remove phpcs ignores.

  • catch committed 3c7b7654 on main 
    task: #3571052 Remove D12 deprecated code from Drupal/Components

By:...

catch closed merge request !14774

smustgrave’s picture

smustgrave commented

Can this be marked fixed?

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Yes! Apparently left a tab open. Committed/pushed to main.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.