Problem/Motivation
As a result of the change of the minimum supported core version to 10.3 in parent issue #3565209: [Meta] Drop support for Drupal 10.2 and below, the minimum supported version of PHP should be 8.1, allowing to implement constants with PHP enum classes: Enumerations.
See how the trend is going with some Drupal core or contrib issues:
- #2951046: Allow parsing and writing PHP class constants and enums in YAML files
- #3339746: Coding style for PHP Enumerations
- #3468405: Use Enums
Steps to reproduce
Proposed resolution
Impacted files:
1 - Admin Toolbar Search:
- Constant classes: AdminToolbarSearchConstants
- Test classes using the constants: AdminToolbarSearchSettingsFormTest, AdminToolbarSearchEventsTest, AdminToolbarSearchTestBase
- Module file: admin_toolbar_search.module
2 - Admin Toolbar Tools:
- Constant classes: AdminToolbarToolsConstants
- Test classes using the constants: AdminToolbarToolsExtraLinksCustomTest, AdminToolbarToolsExtraLinksTest, AdminToolbarToolsEntityCreationTrait
Remaining tasks
User interface changes
API changes
Data model changes
Issue fork admin_toolbar-3570714
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
dydave commentedQuick follow-up on this issue:
All the changes detailed in the issue summary have been implemented and described in the merge request MR !204 above at #2.
Since all the tests and jobs still seem to be passing 🟢, moving issue to Needs review as an attempt to get more testing feedback and reviews.
These changes require Drupal core 10.2 or higher and should probably be merged after related:
#3569351: Drop support for Drupal 10.2 and below
Feel free to let us know if you have any comments, questions or concerns on any aspects of this issue or the suggested changes in the merge request, we would surely be glad to help.
Thanks in advance!
Comment #4
dydave commented