Problem/Motivation

Module throws some deprecation notices when running on PHP 8.4:

Deprecated: Drupal\insert_view_adv\Form\InsertViewDialog::buildForm(): Implicitly marking parameter $filter_format as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/docroot/modules/contrib/insert_view_adv/src/Form/InsertViewDialog.php on line 307

Deprecated: Drupal\insert_view_adv\Controller\AdvancedInsertViewController::ajaxView(): Implicitly marking parameter $filter_format as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/docroot/modules/contrib/insert_view_adv/src/Controller/AdvancedInsertViewController.php on line 61

Steps to reproduce

Install module on Drupal running on PHP 8.4. Run drush cr or something similar and you should see the notices.

Issue fork insert_view_adv-3570309

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dhansen created an issue. See original summary.

dhansen opened merge request !7

dhansen’s picture

dhansen commented
Status: Active » Needs review
a.dmitriiev’s picture

a.dmitriiev commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

a.dmitriiev’s picture

a.dmitriiev commented

Thank you @dhansen. I have merged your changes and released 2.0.0 version, see here https://www.drupal.org/project/insert_view_adv/releases/2.0.0

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.