Problem/Motivation

The menu_traditional view displays Table Menu and Stacked Menu are intended to allow the field_menu_group taxonomy term to be used as a contextual filter.

Proposed resolution

Add Taxonomy term Name as a contextual display setting default to Display all results, but remove the argument from the page displays.

Remaining tasks

Make the change and re-export the view.

Data model changes

views.view.menu_traditional changes

Issue fork bistro-3569294

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mradcliffe created an issue. See original summary.

nickolaj made their first commit to this issue’s fork.

nickolaj’s picture

nickolaj
Primary language Ukrainian
commented
Status: Active » Needs review

Added taxonomy term name contextual filter to the menu_traditional view using the field_menu_group relationship. When no argument is provided, displays all results.

nickolaj opened merge request !3

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Issue summary: View changes
Status: Needs review » Needs work

Thank you for working on this, @nickolaj.

I found an issue with the change and mad ea comment on the merge request. I updated the proposed resolution to reflect that.

nickolaj changed the visibility of the branch 3569294-fix to hidden.

nickolaj’s picture

nickolaj
Primary language Ukrainian
commented
Status: Needs work » Needs review

Updated the MR. The contextual filter argument is now explicitly removed from the page displays (page_stacked and page_table) by overriding arguments: {} and setting arguments: false in their defaults. This way the argument only applies to the default and embed displays, and the page displays are not affected.

  • mradcliffe committed 5ff41eba on 1.0.x authored by nickolaj 
    task: #3569294 Add taxonomy term contextual filter to traditional_menu...
mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Status: Needs review » Fixed

Thank you for coming back and changing things up.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.