Problem/Motivation

Noticed a form error, in a special case the for attribute was missing from a datetime label.
Spun from another twig fix #3568044: wet-boew compliance - form-required and js-form-required classes are redundant to required

Steps to reproduce

Theme the node form with wxt_bootstrap
Might occur in other cases.

Proposed resolution

css to ensure datepicker displays correctly

twig to ensure datetime wrapper label has valid for attribute (wcag compliance)

Here's the latest patch.

Remaining tasks

Review patch for wxt_bootstrap

User interface changes

Resolve browser console error(s).

API changes

Twig change

Data model changes

N/A

Comments

joseph.olstad created an issue. See original summary.

joseph.olstad’s picture

Issue summary: View changes
StatusFileSize
new857 bytes

Patch file for wxt_bootstrap

joseph.olstad’s picture

Assigned: joseph.olstad » Unassigned
Status: Active » Needs review
joseph.olstad’s picture

Status: Needs review » Active

I have an improvement/update for this, coming shortly.

joseph.olstad’s picture

Status: Active » Needs review
StatusFileSize
new1.23 KB
joseph.olstad’s picture

StatusFileSize
new6.12 KB
new6 KB

forget the before, that was a partial patch #5

With patch #5
with patch #5

joseph.olstad’s picture

ah w00ps, actually both of these patches are needed.

joseph.olstad’s picture

joseph.olstad’s picture

StatusFileSize
new2.01 KB

ok, I combined both patches into one.

joseph.olstad’s picture

Issue summary: View changes
joseph.olstad’s picture

Assigned: Unassigned » joseph.olstad
Status: Needs review » Active

still working on this. Will upload a new patch

joseph.olstad’s picture

StatusFileSize
new2.44 KB

Ok this seems to resolve all the date field issues. The other related fields are functioning afaik.

joseph.olstad’s picture

Screenshots using twig from patch 12

looks good

required date

joseph.olstad’s picture

still reviewing

joseph.olstad’s picture

Ensures datepicker date fields month widget shows up to the right of the input box.

div.wb-frmvld {
  div.webform-type-date {
    label {
      display: block;
    }
    input.form-text {
      display: inline-block;
    }
  }
}
joseph.olstad’s picture

Assigned: joseph.olstad » Unassigned
joseph.olstad’s picture

Assigned: Unassigned » joseph.olstad

ok, going to roll that css into the patch. I also have a helper module for webforms that I will add in a new issue.

joseph.olstad’s picture

StatusFileSize
new3.86 KB

New patch, includes the css this time.

joseph.olstad’s picture

Issue summary: View changes
joseph.olstad’s picture

smulvih2’s picture

Version: 6.2.x-dev » 6.3.x-dev
Status: Active » Fixed

Tested this on 6.3.x, and it fixes the WCAG issue as advertised. Pushed a new wxt_bootstrap version 11.3.x and pulled into the latest WxT 6.3.x.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.