Problem/Motivation

After doing the migration steps to Acquia DAM module and disabling the Media AcquiaDAM module the embed images or assets on CKEditor stopped rendering doe the missing Entity browser and embed button.

I do not see any steps related to disabling Media Acquia DAM module and any reference related to embed entities.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

aluzzardi created an issue. See original summary.

aurora.luzzardi’s picture

My current workaround was reverting this deleted configs:

config/default/embed.button.acquia_dam.yml
config/default/entity_browser.browser.document_browser.yml
config/default/entity_browser.browser.media_browser.yml
config/default/entity_browser.browser.wysiwyg_acquia_dam_entity_browser.yml

Manually change the modules dependencies to remove the dependency on the media_acquiadam to set as media:

dependencies:
  module:
    - media

Run the config import and add a custom CSS to hide the Embed Media buttom from CKEditor to stop using it.

/**
* Hide the Acquia DAM button in CKEditor toolbar
*/
.cke_button.cke_button__acquia_dam {
display: none !important;
}

It would be great to have some information on how to properly handle the Entity Embed and Entity Browser and why they are not migrated during the process.

rajeshreeputra’s picture

Please share step to create embed entity using Media: Acquia DAM, will look into it. Regarding Entity Browser it's already taken care as part of migration, see.

rajeshreeputra’s picture

Project: Acquia DAM » Media: Acquia DAM
Version: 1.1.9 » 2.1.2
rajeshreeputra’s picture

Version: 2.1.2 » 2.x-dev

Moved to Media: Acquia DAM module's issue queue.

nickolaj made their first commit to this issue’s fork.

nickolaj’s picture

Status: Active » Needs review

This patch updates the migration process to automatically update module dependencies in embed button and entity browser configurations from `media_acquiadam` to `media`, ensuring these configs remain functional after the migration completes and the legacy module is disabled.

aurora.luzzardi’s picture

Hi rajeshreeputra,

I'm not sure how those were created as I'm not the first developer of the project, but by my testing shows that it was used together with the modules:
Entity Browser
Entity Embed

The entity browser was created using EntityBrowser widget from the Media AcquiaDAM module.
The Entity Embed after uses that EntityBrowser to allow insert media via CKEditor.

I will test the patch from nickolaj to see if solve the issue too.

aurora.luzzardi’s picture

Title: After migrating to Acquia DAM module, Embed Entities top showing » After migrating to Acquia DAM module, Embed Entities not showing
aurora.luzzardi’s picture

nickolaj your patch only applies the workaround to remove media_acquiadam from the configuration. However, this does not restore Entity Browser or Entity Embed functionality.

The reason is that the Acquia DAM module no longer provides the required Entity Browser widget to support Entity Browser–based embeds. That widget exists only in the legacy Media Acquia DAM module. It appears that the Acquia DAM module has intentionally dropped support for Entity Browser in favor of using Drupal’s newer Media embed approach.

I’m fine proceeding with the patch as-is, as I can add CSS at the project level to hide the old Entity Embed button. However, for other projects, this change may cause confusion unless the behavior change is clearly documented and communicated, since Entity Browser–based embeds will no longer be available.

aurora.luzzardi’s picture

Status: Needs review » Needs work
japerry’s picture

Status: Needs work » Needs review

I’m fine proceeding with the patch as-is, as I can add CSS at the project level to hide the old Entity Embed button. However, for other projects, this change may cause confusion unless the behavior change is clearly documented and communicated, since Entity Browser–based embeds will no longer be available.

I'd agree to be hesitant to auto-update / remove Entity browser on a global basis, but I think the point about adding specific documentation on migrating away from Entity Browser is very relevant.

pavlosdan’s picture

"All functionality of Media: Acquia DAM has been brought into Acquia DAM 1.1.5+. Migrate Today!"

I'd argue that this line implies that Entity Browser should be supported. Why force a move away from Entity Browser? That's still a widely used and relevant module.

pavlosdan’s picture

And if support is dropped, then we need to have an upgrade path from entity browser to media library.

rajeshreeputra’s picture

Status: Needs review » Needs work

Kept the existing MR intact and created a new one to support the migration of the Entity Embed button.

rajeshreeputra’s picture

Status: Needs work » Needs review

Requesting review.

rajeshreeputra’s picture

Status: Needs review » Fixed

Merged!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.