Problem/Motivation

Scaffold panel has ::buildComponentSettingItem() private static method which is hardcoding logic from SDC and the Icon API, and mixing it with the building of renderable arrays. Done

Proposed resolution

In order to keep only the renderable logic in LayersPanel::addComponentSettingsSummary() and be future-proof, can we move the data logic to implementations of PluginSettingsInterface::settingsSummary()?

Remaining tasks

For UI Icons see : 3591885

By removing hardcoded SDC logic, this will also help the work on #3531521: Layout plugins support. Done

Comments

pdureau created an issue. See original summary.

pdureau’s picture

Title: Replace LayersPanel::buildComponentSettingItem() by usage of PluginSettingsInterface::settingsSummary() » Leverage PluginSettingsInterface::settingsSummary() in LayersPanel
mogtofu33’s picture

Sure, main work is on the ui_patterns side which give only the variant currently, issue created: #3568363: Add settings form values to the component settingsSummary()..

The UI icons do not need much and can work as it is.

pdureau’s picture

pdureau’s picture

LayersPanel is already leveraging PluginSettingsInterface::settingsSummary() (PluginSettingsInterface::settingsSummary() still exists but there is no much logic left)

So I guess this issue is kept opened to clean our implementation once #3568363: Add settings form values to the component settingsSummary(). is merged

mogtofu33’s picture

Assigned: Unassigned » mogtofu33
Status: Active » Needs work
Issue tags: -display_builder-1.0.0-beta4 +display_builder-1.0.0-beta5
mogtofu33’s picture

Assigned: mogtofu33 » Unassigned
Status: Needs work » Active
Issue tags: -display_builder-1.0.0-beta5
mogtofu33’s picture

mogtofu33’s picture

Assigned: Unassigned » mogtofu33
Status: Active » Needs work
mogtofu33’s picture

Assigned: mogtofu33 » Unassigned
Status: Needs work » Postponed

Waiting on UI Patterns issue.

mogtofu33’s picture

Issue summary: View changes
mogtofu33’s picture

Issue summary: View changes
Status: Postponed » Active
mogtofu33’s picture

Issue summary: View changes
mogtofu33’s picture

Issue summary: View changes
mogtofu33’s picture

Issue summary: View changes