Problem/Motivation

We have Styles summary on layers panel, would be great to have the Config summary as well.

Steps to reproduce

Proposed resolution

Either we change the current ThirdPartySettingsInterface that is too specific to third_party_settings, add it to ContextualFormPanel island and make it higher level.

Either we can start by simply adding a summary process based on component 'props' in the layers panel.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 summaries.png59.53 KBpdureau

Issue fork display_builder-3564094

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mogtofu33 created an issue. See original summary.

mogtofu33’s picture

mogtofu33 commented
Status: Active » Needs review
pdureau’s picture

pdureau commented

Each node has 4 keys:

  • node_id (string)
  • source_id (string)
  • source (array)
  • third_party_settings (array)

The summary of the config stored in source is already managed by the plugin identified in source_id through \Drupal\ui_patterns\PluginSettingsInterface::settingsSummary() and displayed on the start side of the layer:

summaries

So, for component props, would it be enough to simply extends ComponentSource::settingsSummary() (which is today only adding the variant)?

pdureau’s picture

pdureau commented
StatusFileSize
new summaries.png59.53 KB
mogtofu33’s picture

mogtofu33 commented
Assigned: Unassigned » pdureau

Off course ComponentSource::settingsSummary() would be a good place, but as today it only add variant. So this is a quick win to have the config available in layer, and we can have a follow up to add it in UI Patterns.

pdureau’s picture

pdureau commented

Is there a MR to review?

mogtofu33 opened merge request !203

  • mogtofu33 committed 27ea0966 on 1.0.x 
    feat: #3564094 Add component config summary on layers

by: mogtofu33
mogtofu33’s picture

mogtofu33 commented
Assigned: pdureau » Unassigned
Status: Needs review » Needs work

Quick win for beta1, keep open to have better.

mogtofu33’s picture

mogtofu33 commented
Status: Needs work » Fixed

Follow up work is on #3568329: Leverage PluginSettingsInterface::settingsSummary() in LayersPanel

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.