Problem/Motivation
Contextual .module only has a couple remaining functions.
See #3566536: [meta] eliminate core .module files.
Proposed resolution
Create new ContextualLinksSerializer service.
Add linkToId and idToLinks methods
Replace calls to deprecated methods.
Remaining tasks
N/A
User interface changes
N/A
Introduced terminology
N/A
API changes
N/A
Data model changes
N/A
Release notes snippet
N/A
Issue fork drupal-3568087
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3568087-contextual.module
changes, plain diff MR !14380
Comments
Comment #3
claudiu.cristeaReady for review.
Comment #4
dcam commentedThe MR looks good to me, as does the change record. I wondered if the controller needed the backward compatibility, but @longwave requested it in #3398528: Add support for autowiring to controller methods, so it's probably a good idea.
Comment #5
nicxvan commentedComment #6
nicxvan commentedI updated the issue summary.
I think this looks great but one question that I know will come up is these functions were not api before but are with this change.
Should we mark the service as internal?
I think it's fine to keep contained in a small service since it's used in two places.
Comment #7
larowlanJust one minor question, feel free to self RTBC/reject
Comment #8
claudiu.cristeaInjected the service.
Comment #12
larowlanCommitted to main and backported to 11.x - thanks!