Describe your bug or feature request.

With GIN, Commerce configuration items are lacking icons (See the screenshot below):

That seems to be due to the GIN CSS taking precedence over the selectors used in commerce.toolbar.css.

Let's address that.

CommentFileSizeAuthor
#2 gin-with-icons.png9.8 KBjsacksick
icons-missing-with-gin.png9.13 KBjsacksick

Issue fork commerce-3567944

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jsacksick created an issue. See original summary.

jsacksick’s picture

jsacksick commented
Status: Active » Needs review
StatusFileSize
new gin-with-icons.png9.8 KB

After fixing the selectors:

Gin icons

jsacksick opened merge request !591

jsacksick’s picture

jsacksick commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

jsacksick’s picture

jsacksick commented
Status: Fixed » Active

The Commerce icon changed, we now override the cart icon that ships with GIN, so we likely need update our icon.

majmunbog made their first commit to this issue’s fork.

majmunbog opened merge request !593

majmunbog’s picture

majmunbog commented
Status: Active » Needs review

I've added a new set of icons and assigned them to the --icon CSS variable (which Gin uses for toolbar icons) to outline versions that match Gin's design system. This updates the icons in Gin while keeping the filled versions for other themes.

jsacksick’s picture

jsacksick commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.