Problem/Motivation

The logic added in #3423451: Automatically update config when content types are created or deleted contains a flaw: when checking whether there is already configuration for a given node type, the wrong variable is used. This leads to the configuration being overridden, in particular in a config sync.

Steps to reproduce

  1. Leave the "Enable node types automatically" option off
  2. Create a new new type and enable the "Save & Edit" link for it manually
  3. Export configuration
  4. Install the site again from existing configuration (not sure if a config import on a different site is also sufficient to replicate this, didn't try that)

Expectation: The "Save & Edit" is enabled for that node type.
Result: It is no

Proposed resolution

Fix the check for the existing node type configuration.

Remaining tasks

User interface changes

-

API changes

-

Data model changes

-

Issue fork save_edit-3567942

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tstoeckler created an issue. See original summary.

tstoeckler opened merge request !13

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Title: Avoid changing configuration during an installaion from config » Avoid changing configuration during an installation from config
Status: Active » Needs review
caesius’s picture

caesius commented
Status: Needs review » Reviewed & tested by the community

Thanks, merged

caesius’s picture

caesius commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.