Problem/Motivation

We recently setup the theme for a french camp and many elements appear to be hardcoded, like the date formats or some strings here and there.

I open this issue to work on a MR to fix these issues. We'll probably be focused on avoiding any kind of regression for the current setup.

Steps to reproduce

Install the theme.
Add a language different than english.
Try to translate all the UI.

Proposed resolution

I suggest a more common usage of the t() method in the components templates and perhaps also the usage of proper date formats rather than custom date outputs.

CommentFileSizeAuthor
#8 3567696-7.patch13.58 KBnicoloye
#7 3567696-7.patch.patch13.58 KBnicoloye
#6 3567696-6.patch12.12 KBnicoloye
#5 3567696-5.patch9.88 KBnicoloye

Issue fork event_horizon-3567696

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nicoloye created an issue. See original summary.

nicoloye changed the visibility of the branch 3567696-translation-issues to hidden.

nicoloye changed the visibility of the branch 3567696-translation-issues to active.

nicoloye opened merge request !14

nicoloye’s picture

nicoloye commented
StatusFileSize
new 3567696-5.patch9.88 KB

Posting the patch for test purposes.

nicoloye’s picture

nicoloye commented
StatusFileSize
new 3567696-6.patch12.12 KB

Posting the patch for test purposes.

nicoloye’s picture

nicoloye commented
StatusFileSize
new 3567696-7.patch.patch13.58 KB

Posting patch for test purposes.

nicoloye’s picture

nicoloye commented
StatusFileSize
new 3567696-7.patch13.58 KB
nicoloye’s picture

nicoloye commented
Status: Active » Needs review

mandclu made their first commit to this issue’s fork.

  • mandclu committed d1014db2 on 1.0.x authored by nicoloye 
    fix: #3567696 Translation issues

By: nicoloye
By: mandclu
mandclu’s picture

mandclu commented
Status: Needs review » Fixed

Thanks for your work on this. Merged in

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.