Problem/Motivation

Track the steps needed to deprecate extension Stable 9 from core to contrib. See Remove a core extension and move it to a contributed project of the deprecation policy.

The removal of extension Stable 9 was approved in #3512287: [policy, no patch] Deprecate Stable9 and move to contrib.

Remaining tasks

Postponed on sibling issues that remove integrations of Stable9

  1. Create a section on Deprecated and obsolete modules and themes to provide recommendations for sites using extension Stable 9. The recommendations are to include instructions for sites using the extension and for contributed projects that depend on then extension.
  2. Add the following to the extension info.yml file

    3. lifecycle: deprecated
    lifecycle_link: https://www.drupal.org/node/3223395#s-stable-9

  3. Add #[IgnoreDeprecations] to all tests in the extension.
  4. Add a change record and include a link the the doc page.
  5. Deprecate any library that is only used by the extension.
  6. Do a thorough search of core for any remaining references to the extension. If references are found, outside of the extension, then creates issues to remove the references.

Release notes snippet

Issue fork drupal-3567667

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

andypost made their first commit to this issue’s fork.

andypost opened merge request !14864

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Postponed » Needs review

Looks like all tests pass now, there's base theme: stable9 but it does not affect remaining tests

andypost’s picture

andypost
he/him
Primary language Russian
commented

Not really sure about stark vs test_base_theme but idea was to prefer to use test theme (especially when hidden: true is supposed) and functional-js tests prefer stark as require enable theme in UI

quietone’s picture

quietone commented
Issue summary: View changes
Status: Needs review » Postponed

This has changes that are out of scope, this issue should only be doing the tasks in the issue summary. There are only 13 files changed so maybe that is OK in this case.

.. maybe not

I checked this out and searched for 'stable9' there are still 27 uses in core.

Therefore, I am going to move the work to add a new test theme to a new issue and keep this solely for the deprecation.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Related issues: +#3575876: Replace stable9 with test_theme_base theme in tests

Good idea to introduce a replacement - it will simplify removal #3575876: Replace stable9 with test_theme_base theme in tests

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Postponed » Needs review

looks ready

smustgrave’s picture

smustgrave commented

See MR is in draft is there additional work? Also do we need a CR on this issue?

quietone’s picture

quietone commented

It was only after I rebased that I noticed the tests have not been moved. All the tests for an extension should be in the extension directory before deprecation and that should be done in a separate issue. However, there are only 2 tests so it is not adding noise to this issue, so let's no make more work for ourselves.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

Looks ready

  • catch committed 21add4b1 on main 
    task: #3567667 Deprecate Stable9

By: quietone
By: andypost
catch’s picture

catch
he/him
Primary language English
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed/pushed to main, thanks!

This will need a backport MR - conflict in Stable9TemplateOverrideTest

catch closed merge request !14864

quietone reopened merge request !14864

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Patch (to be ported) » Reviewed & tested by the community

Thank you, looks ready

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Reviewed & tested by the community » Needs work

needs work as better to open new MR

quietone closed merge request !14864

quietone opened merge request !15238

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Reviewed & tested by the community

Nice, ready to go in

  • catch committed b86ae107 on 11.x 
    task: #3567667 Deprecate Stable9

By: quietone
By: andypost
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

catch closed merge request !15238

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

quietone’s picture

quietone commented
Issue tags: +11.4.0 release notes