Problem/Motivation

This is to remove history from the standard profile, umami profile and the standard recipe.

The removal of extension History module was approved in #3336276: [Policy] Deprecate History module.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3567650

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone opened merge request !14350

quietone’s picture

quietone commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

This was tough to review :)

LGTM to me, hopefully in 12 we start to look into that standard/minimal hybrid I've heard about.

quietone’s picture

quietone commented
Title: Remove history from the standard profile » Remove history from profiles and recipes
Issue summary: View changes
Status: Reviewed & tested by the community » Needs work

Expanding the scope.

Not sure how to fix the failing test, the byte count being tested changes. \Drupal\Tests\demo_umami\FunctionalJavascript\AssetAggregationAcrossPagesTest::testFrontAndRecipesPagesAuthenticated

smustgrave’s picture

smustgrave commented

Can’t we just adjust the number?

longwave made their first commit to this issue’s fork.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Needs review

I think I fixed them; the process is to take the actual number of bytes reported in the test failure, then we round it to the nearest 50 (the byte counts differ anyway, because of slight differences between environments).

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

The changes since the last RTBC look good to me. grep -r "history" core/recipes/, grep -r "history" core/profiles/demo_umami/, and grep -r "history" core/profiles/standard/ all returned zero results. So I don't think there's anything else that might be in-scope.

quietone’s picture

quietone commented

@longwave, thanks for the explanation.

  • catch committed c01cec09 on 11.x 
    task: #3567650 Remove history from profiles and recipes

By: quietone
By...

  • catch committed 33a30684 on main 
    task: #3567650 Remove history from profiles and recipes

By: quietone
By...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

The bytes change is because the history library is the only library on those pages that depends on AJAX (especially now that big_pipe has been converted to htmx), so the amount of js we remove from those pages is quite significant.

As I was committing this I realised we probably need a change record, so added one.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

catch closed merge request !14350

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.