Problem/Motivation

Track the steps needed to deprecate extension History module. See Remove a core module and move it to a contributed project of the deprecation policy.

The removal of extension History module was approved in #3336276: [Policy] Deprecate History module.

Remaining tasks

  1. @andypost has offered to maintain the contrib version of the extension.
  2. Move integrations implemented by other modules to the extension.
    Create child issues or child meta issues, as needed, to address the following points. Not all points will apply to all extensions.
  3. Do a thorough search of core for any remaining references to the extension. If references are found, outside of the extension, then create issues to remove the references.
  4. Create the contrib project with a stable release, before the alpha version of the major release. Follow the process in Create the contrib project with a stable release for creating the sub tree split.
  5. Deprecate the core extension. #3520472: Deprecate the History module
  6. #3567858: Ensure that History does not get special core treatment

Comments

quietone created an issue. See original summary.

quietone’s picture

quietone commented
Component: contact.module » history.module
andypost’s picture

andypost
he/him
Primary language Russian
commented

Filed contrib issue to start ball roll #3521740: Add andypost as co-maintainer to transfer core history module

quietone’s picture

quietone commented
Issue summary: View changes
quietone’s picture

quietone commented
Issue summary: View changes
berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Started commenting in #3524379: [meta] Remove usage of history module from comment module but moving into this issue.

I wonder if the decision to remove history module took into consideration how many features in comment module depend on it, there's a reason that history remained in core until now, this is going to be tough to untangle. That said, it's also clear that not a lot of sites these days actually rely on this feature (based on personal experience). The same can be said about comment module too I suppose.

Removal of history in D12 seems to conflict with new deprecation policy a bit. We will need to deprecate controllers/routes, views handlers, libraries and functionality to be able to remove history. It will likely not affect many modules in practice, if at all, but still, it's quite a lot and it would need to land very soon.

Might need to move history removal to D13.

I actually wonder if we should consider to instead just move comment.module as well into contrib and keep them entangled?

quietone’s picture

quietone commented
Issue summary: View changes
xjm’s picture

xjm
she/her
Primary language English
commented

@berdir re: #6, we actually raised some of the same concerns about the architectural entanglement with comment in #3336276-4: [Policy] Deprecate History module. When it was discussed again 18-some months later at DrupalCon Barcelona there was consensus among the Core Leadership Team to sign off on remove it, but that doesn't mean we're requiring that it be removed before Drupal 12 or anything. So we did take it into consideration, but I can also definitely see it happening in D13 instead of D12.

I was talking about this with @andypost in person at DrupalCon Vienna while reading @berdir's comment.

quietone’s picture

quietone commented
Issue summary: View changes

history is no longer used in these tests \Drupal\Tests\views\Kernel\Handler\HandlerAllTest and \Drupal\Tests\views\Kernel\TestViewsTest.

quietone’s picture

quietone commented
Issue summary: View changes
quietone’s picture

quietone commented
Issue summary: View changes
quietone’s picture

quietone commented
Issue summary: View changes
quietone’s picture

quietone commented
Issue summary: View changes

Did some searching and found usages below.

  • core/modules/comment/src/CommentManager.php
  • core/modules/comment/src/Controller/CommentController.php
  • core/modules/comment/src/Plugin/views/field/NodeNewComments.php
  • core/modules/node/node.module
  • core/modules/views/tests/modules/views_test_config/test_views/views.view.test_history.yml
  • core/modules/views/tests/src/Kernel/TestViewsTest.php
  • core/profiles/demo_umami/tests/src/FunctionalJavascript/OpenTelemetryAuthenticatedPerformanceTest.php
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Re #13

The first four are deprecations that will be removed in Drupal 12.

I opened #3568027: Move views.view.test_history to history module for the test view.

TestViewsTest only has a comment so I think it can be safely removed.

OpenTelemetryAuthenticatedPerformanceTest will be solved by #3567650: Remove history from profiles and recipes

quietone’s picture

quietone commented
Issue summary: View changes
quietone’s picture

quietone commented
Status: Active » Needs review

A search for 'history' finds many usages that are not relevant to the History module. But, I think that all the usages have been fixed.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Yeah there are a lot of false positives, but I also can't find any remaining true references outside of history.module that aren't already deprecated and scheduled for removal.

smustgrave’s picture

smustgrave commented

Seems only remaining task is to get andypost access to the contrib namespace. I posted in #drupalorg channel if anyone can help.

smustgrave’s picture

smustgrave commented
Status: Needs review » Active

Seems like we still need to get andypost added as maintainer of the contrib space. And in slack seems to be no clear way to get it done quickly. If we go though the standard adopt a module process then this will be another 2-4 weeks

smustgrave’s picture

smustgrave commented
Status: Active » Reviewed & tested by the community

And that's now resolved, congrats @andypost!

quietone’s picture

quietone commented

@smustgrave, thanks for coordinating the ownership change of the History module in contrib.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

andypost’s picture

andypost
he/him
Primary language Russian
commented

version 1.0.0 tagged and released https://www.drupal.org/project/history/releases/1.0.0

andypost’s picture

andypost
he/him
Primary language Russian
commented

Unpostponed last issue left #3567858: Ensure that History does not get special core treatment

Probably it needs one more issue to remove the module from core

andypost’s picture

andypost
he/him
Primary language Russian
commented
Related issues: +#3520468: [meta] Tasks to remove History module
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Fixed

I think the deprecation is all done and the removal issue is open, let's close this out.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

quietone’s picture

quietone commented

I updated the credit for this.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.