Problem/Motivation

_help_search_update is only used by a couple of hook methods
Move it to HelpHooks as a protected method

Steps to reproduce

N/A

Proposed resolution

Move to protected method
Combine the themes installed and themes uninstalled hook since they are identical

Remaining tasks

Create follow up to remove plugin cache clearer from themes installed and uninstalled, we now do that on all theme install and uninstall

User interface changes

N/A

Introduced terminology

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

Issue fork drupal-3567616

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nicxvan created an issue. See original summary.

nicxvan’s picture

nicxvan commented
Issue summary: View changes

nicxvan opened merge request !14348

nicxvan’s picture

nicxvan commented
Status: Active » Needs review
dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

Looks ok to me. I installed the MR. The search index is still updated when installing and uninstalling.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

larowlan closed merge request !14348

  • larowlan committed 130e4226 on 11.x 
    task: #3567616 Move _help_search_update to hook

By: nicxvan
(cherry...

  • larowlan committed e35a5a07 on main 
    task: #3567616 Move _help_search_update to hook

By: nicxvan
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Version: main » 11.1.x-dev
Status: Reviewed & tested by the community » Fixed

Commited to main and backported to 11.x

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.