Problem/Motivation

actions() creates the value of $create_button_text in all cases, but only uses it if 

    if ($this->entity->isNew()) {

Steps to reproduce

Proposed resolution

Move it all into the if() block.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork flag-3567460

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

joachim created an issue. See original summary.

sujal kshatri made their first commit to this issue’s fork.

sujal kshatri opened merge request !192

sujal kshatri’s picture

sujal kshatri commented
Status: Active » Needs review

Hey,
I’ve moved the creation of $create_button_text inside the if ($this->entity->isNew()) block in FlaggingForm::actions(), as requested.
If any further changes are needed, please let me know

ivnish’s picture

ivnish
he/him
commented

Straight forward

  • ivnish committed 09544685 on 5.x authored by sujal kshatri 
    task: #3567460 FlaggingForm should only make $create_button_text once it...
ivnish’s picture

ivnish
he/him
commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.