Problem/Motivation

PHP 8.4 has been released, and this module is triggering a "use explicit nullable type" deprecation.

This is part of Drupal's coding standards now, but since the issues to fix phpcs in this module have stalled, I'm opening up this issue to fix this single deprecation to avoid the warnings on PHP 8.4.

After updating to PHP 8.4:

------ -----------------------------------------------------------------------------------------------------------------------------------------------
Line src/Form/HmOverviewTerms.php
------ -----------------------------------------------------------------------------------------------------------------------------------------------
31 Deprecated in PHP 8.4: Parameter #3 $taxonomy_vocabulary (Drupal\taxonomy\VocabularyInterface) is implicitly nullable via default value null.
------ -----------------------------------------------------------------------------------------------------------------------------------------------

------ --------------------------------------------------------------------------------------------------------------------------------------
Line src/Plugin/HmDisplayPlugin/HmDisplayJstree.php
------ --------------------------------------------------------------------------------------------------------------------------------------
26 Deprecated in PHP 8.4: Parameter #4 $form_state (Drupal\Core\Form\FormStateInterface) is implicitly nullable via default value null.
------ --------------------------------------------------------------------------------------------------------------------------------------

------ --------------------------------------------------------------------------------------------------------------------------------------
Line src/Plugin/HmDisplayPluginInterface.php
------ --------------------------------------------------------------------------------------------------------------------------------------
16 Deprecated in PHP 8.4: Parameter #4 $form_state (Drupal\Core\Form\FormStateInterface) is implicitly nullable via default value null.
------ --------------------------------------------------------------------------------------------------------------------------------------

CommentFileSizeAuthor
#2 3567185-php-8.4-deprecation.patch2.37 KBbenjy44

Comments

benjy44 created an issue. See original summary.

benjy44’s picture

Status: Active » Needs review
StatusFileSize
new2.37 KB

Patch to fix warning on version 3.4.1

mkalkbrenner’s picture

Version: 3.4.1 » 3.x-dev
Status: Needs review » Reviewed & tested by the community

  • 33b8a081 committed on 3.x
    Issue #3567185 by benjy44, mkalkbrenner, mingsong: PHP 8.4 implicit...
mingsong’s picture

Status: Reviewed & tested by the community » Fixed

Thanks.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.