Problem/Motivation

Canvas is updating how CandidateStorablePropShape should be altered. This means Acquia DAM needs to update it's integration code.

Proposed resolution

Remove a lot of now redundant code, use new "branches" concept instead.

Remaining tasks

Tests, maybe update path?

Issue fork acquia_dam-3566969

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

f.mazeikis created an issue. See original summary.

f.mazeikis opened merge request !244

f.mazeikis’s picture

f.mazeikis commented
Status: Active » Needs review

This needs review, but it also depends on #3550750 for testing and reviewing this.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Needs work
Related issues: +#3550750: Adding bundle-specific expression branching support to `ReferenceFieldTypePropExpression`, +#3556464: Match Acquia DAM Video assets for Canvas `video` shape

#3550750: Adding bundle-specific expression branching support to `ReferenceFieldTypePropExpression` is in!

  • f.mazeikis committed b8e1a062 on 1.1.x 
    Resolve #3566969 Refactor Canvas integration to use branches

f.mazeikis opened merge request !251

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

AFAICT this should also bump the required Canvas version, by specifying a conflict with drupal/canvas <1.1 🙏

(That'd prevent installing new Acquia DAM versions that assume Canvas >=1.1.0!)

f.mazeikis’s picture

f.mazeikis commented
Status: Needs work » Reviewed & tested by the community
f.mazeikis’s picture

f.mazeikis commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.