Problem/Motivation

See #3566536: [meta] eliminate core .module files

Proposed resolution

According to "Drupal core backend backwards compatibility and internal API policy", section Underscore-prefixed functions and methods

Functions or methods with an underscore prefix (e.g. _some_function()) are considered internal, and may be used to avoid name collisions when backporting protected methods critical or major bug fixes. Extending code should not call these functions or methods directly nor use the underscore prefix for added methods.

Move _block_content_has_reusable_condition() to a protected method. No need fr depreciation.

Remaining tasks

None.

User interface changes

None.

Introduced terminology

None.

API changes

None.

Data model changes

None.

Issue fork drupal-3566776

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

claudiu.cristea created an issue. See original summary.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Parent issue: » #3566536: [meta] eliminate core .module files

claudiu.cristea opened merge request !14288

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Assigned: claudiu.cristea » Unassigned
Status: Active » Needs review

Ready

nicxvan’s picture

nicxvan commented
Status: Needs review » Reviewed & tested by the community
Related issues: +#2984930: Add hasCondition() method to \Drupal\Core\Database\Query\ConditionInterface

Thanks!

This is an underscore function so no deprecation is necessary and protected makes sense.

I searched gitlab and contrib and there are no usages outside of full drupal core clones.

The comment mentions https://www.drupal.org/project/drupal/issues/2984930 which is still active so no need to change anything.

Looks good to me!

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Fixed

Committed to main and backported to 11.x - thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

larowlan closed merge request !14288

  • larowlan committed c8258128 on 11.x 
    feat: #3566776 Move _block_content_has_reusable_condition() to a...

  • larowlan committed 64584b8c on main 
    feat: #3566776 Move _block_content_has_reusable_condition() to a...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.