Problem/Motivation

Deprecated code in config_distro's ConfigDistroImportForm class triggers exceptions / PHP warnings when this module's PHPUnit tests are run on GitLab CI:

Drupal\Tests\config_sync\Functional\ImportTest::testImportAfterChange
Exception: Warning: Undefined property: Drupal\config_sync\Form\ConfigSyncImportForm::$configManager
Drupal\config_distro\Form\ConfigDistroImportForm->buildForm()() (Line: 48)

The issue has been fixed in Config Distro but the fix has not yet been included in a release (#3566230: Fix remaining Drupal 9+ compatibility issues).

Proposed resolution

Increase minimum version constraint for config_distro to 2.0.0-alpha4 or 2.1.0-alpha2, both of which include a fix for #3566230: Fix remaining Drupal 9+ compatibility issues

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork config_sync-3566744

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

joegraduate created an issue. See original summary.

joegraduate’s picture

joegraduate
Primary language English
Location Arizona, USA
commented
Status: Active » Postponed
Related issues: +#3566740: Config Distro 2.1.0-alpha2 release plan
joegraduate’s picture

joegraduate
Primary language English
Location Arizona, USA
commented
Title: Update config_distro to 2.1.0-alpha2 » Update config_distro to fix failing test
Issue summary: View changes
Status: Postponed » Active
joegraduate’s picture

joegraduate
Primary language English
Location Arizona, USA
commented
Title: Update config_distro to fix failing test » Update config_distro to fix deprecation errors / test failures
joegraduate’s picture

joegraduate
Primary language English
Location Arizona, USA
commented
Related issues: +#3574731: Config Distro 2.0.0-alpha4 release plan

joegraduate opened merge request !26

  • joegraduate committed a2bab1e8 on 3.0.x 
    fix: #3566744 Update config_distro to fix deprecation errors / test...
joegraduate’s picture

joegraduate
Primary language English
Location Arizona, USA
commented
Assigned: joegraduate » Unassigned
Status: Active » Fixed

Merged.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.