Problem/Motivation

After the changes that were added to the module, which allow the shipment created on the order page to be repackable, we still have an issue with repacking, as it does not take into account that the shipment can be created before any order item is added to the order. As a result, the shipment is not repacked when an order item is added/updated. Mainly, it is because of the packer plugins' sequence of execution. The first one that tries to create a ProposedShipment object is the DefaultPacker, wich dependent on the list of order items and returns an empty array. There is a condition in the PackerManager that checks if the packer does not return NULL, and it caused a problem, as the new AdminPacker is not called.

Steps to reproduce

- Create a new draft order without any items in it
- Create a new shipment with the "Add shipping information" modal form on the order view page
- Add new item(s) to the order and check the shipment

Proposed resolution

- Update the condition in PackerManager to check if the returned result by packer is not empty
- Modify the OrderItemSubscriber to recalculate shipments properly

Issue fork commerce_shipping-3566691

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tbkot created an issue. See original summary.

tbkot opened merge request !100

jsacksick’s picture

jsacksick commented
Status: Active » Needs work
Issue tags: +Needs tests

Ok tests are failing on D10 due to the use of getOriginal() which was introduced in D11.
Perhaps Commerce core could introduce a helper so it can be used accross Commerce.

There are phpcs failures.

And ideally we'd add a test to confirm the following:

  1. A shipment is created by clicking the "Add shipping information" link, when the order has no items
  2. The shipment is marked as owned_by_packer after the modal is closed / the form is saved.
  3. Adding order items result in the shipment being repacked / refreshed (i.e items not empty).
  4. We should probably check that the shipment is rated too.
tbkot’s picture

tbkot commented
Status: Needs work » Needs review

A test is added to check the draft shipment creation within an empty draft order.

jsacksick’s picture

jsacksick commented
Status: Needs review » Needs work

Tests are failing, putting this to needs work.

  • jsacksick committed 19649cca on 3.x authored by tbkot 
    fix: #3566691 Draft shipment is not repacked to include items as they're...
jsacksick’s picture

jsacksick commented
Status: Needs work » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.