Problem/Motivation

The short description given for AccountForm::__construct() is Constructs a new EntityForm object.

While the AccountForm class implements an entity form, and one of its parent classes is effectively the EntityForm class, that short description is not correct.

Proposed resolution

Change that short description to Constructs a new \Drupal\user\AccountForm object.

Issue fork drupal-3566568

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

avpaderno created an issue. See original summary.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes

avpaderno opened merge request !14269

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Active » Needs review
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Needs work
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

I apologize: I followed what the Drupal coding standards say.

If you use a namespace on a class anywhere in documentation, always make sure it is a fully-qualified namespace (beginning with a backslash).

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Needs review
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

That isn't entirely clear but I think that's only if you are already fully-qualifying the name, ie. we should say \Drupal\user\AccountForm instead of Drupal\user\AccountForm, but not that we always have to fully qualify class names.

Looks good to me now.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

larowlan closed merge request !14269

  • larowlan committed 65d21370 on 11.3.x 
    fix: #3566568 The short description for the \Drupal\user\AccountForm...

  • larowlan committed da34f773 on 11.x 
    fix: #3566568 The short description for the \Drupal\user\AccountForm...

  • larowlan committed 74379115 on main 
    fix: #3566568 The short description for the \Drupal\user\AccountForm...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Version: main » 11.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed to main and backported to 11.x and 11.3.x

Thanks folks, webchick once granted me this, so I feel its time to pass it on 😉

trivial patch of the month badge

💙 every bit counts

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.