Problem/Motivation

CRM's permission machine names and titles use a mix of styles, which should be standarized.

Steps to reproduce

Proposed resolution

Replace "crm_contact" with "crm contact" to match style of "crm relationship".

Match core's use of emphasis (em tags).

Replace "crm user alter display name" with "alter crm user display name" to make it verb-first.

Standardize use of "any" for non-bundle-specific permissions.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork crm-3566204

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jdleonard created an issue. See original summary.

jdleonard’s picture

jdleonard
he/him
Primary language English
Location Austin, Texas
commented
Issue summary: View changes

jdleonard opened merge request !143

jdleonard’s picture

jdleonard
he/him
Primary language English
Location Austin, Texas
commented
Issue summary: View changes
Status: Active » Needs review
jdleonard’s picture

jdleonard
he/him
Primary language English
Location Austin, Texas
commented
Assigned: jdleonard » Unassigned
jdleonard’s picture

jdleonard
he/him
Primary language English
Location Austin, Texas
commented

Pipeline failure is code coverage task timing out.

bluegeek9 made their first commit to this issue’s fork.

bluegeek9 changed the visibility of the branch 1.0.x to hidden.

svendecabooter’s picture

svendecabooter
he/him
Primary language Dutch
Location Gent
commented

This looks like a good change to me.
The PHPUnit test seems to fail - presumably caused by PHPUnit 12 deprecations?
See https://www.drupal.org/node/3548485

svendecabooter’s picture

svendecabooter
he/him
Primary language Dutch
Location Gent
commented
Status: Needs review » Reviewed & tested by the community

Test failure seemed to have been a temporary hickup.
Marking as RTBC, as this looks good to me.

bluegeek9’s picture

bluegeek9 commented
Status: Reviewed & tested by the community » Fixed
//www.flaticon.com/free-icons/thank-you Thank you for your contribution! Your continued support makes this project sustainable.
There are multiple ways to show appreciation for the work contributed to this project including:
  • Triage issues and adding more context to existing issues.
  • Flagging CRM as a favorite on the project page to help others discover it and show your support.
  • Review the Developer Docs for accuracy and clarity.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.