Problem/Motivation

Search is being deprecated, see the parent issue for details. This issue is for removing Search from the standard profile.

For an example see how this was done for the RDF module in #3243121: Remove RDF module from the Standard profile.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3565822

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone opened merge request !14229

quietone’s picture

quietone commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Left a comment on the MR.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Assigned: Unassigned » amber himes matz

@Amber Matz please take a loot at wording as it blocker

quietone’s picture

quietone commented
Status: Needs work » Needs review

I removed the unneeded 'the' and renamed a file. Back to NR

amber himes matz made their first commit to this issue’s fork.

amber himes matz’s picture

amber himes matz
she/her
Primary language English
Location Portland, OR USA
commented

The help_search_topic variable "set" was removed from the top of core/modules/help/help_topics/help.overview.html.twig, but not its variable output in the last paragraph, so that would have resulted in an error.

I updated that last paragraph in help.overview.html.twig to remove the parenthetical statement about configuring help search, which seemed like an extra detail that may or may not be true in the future. I also removed the sentence referring to and linking to the now-deleted related help search topic.

Looks like the fork needs to be updated now, though.

amber himes matz’s picture

amber himes matz
she/her
Primary language English
Location Portland, OR USA
commented
Assigned: amber himes matz » Unassigned

I'm not sure where the merge conflict is happening. I followed the instructions in gitlab to resolve the merge conflict locally, but my git status is clean, so I'm not sure what to do here. I clicked the "Rebase" button in the GitLab UI, but it failed.

amber himes matz’s picture

amber himes matz
she/her
Primary language English
Location Portland, OR USA
commented
Status: Needs review » Needs work
andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Needs review

rebased 4 commits against `main` https://git.drupalcode.org/project/drupal/-/merge_requests/14229

I think top_level: true is not needed for moved topic

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

I think it ready to go

godotislate’s picture

godotislate
he/him
commented
Status: Reviewed & tested by the community » Needs work

A couple comments about wording and grammar:

you will need to install a contributed Search

It will be just the one specific "Search" module, not any search module, so I think "the" is more appropriate?

the words, "walk, walking, and walked".

Don't think the comma is necessary here, and the words should be individually quoted.

First one I could go either way on, but the second one I think the quotations marks need fixing.

quietone’s picture

quietone commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

believe feedback for this one has been addressed.

godotislate closed merge request !14229

  • godotislate committed fe6a9ab9 on main 
    refactor: #3565822 Move mention of Search from core help to search...
godotislate’s picture

godotislate
he/him
commented
Status: Reviewed & tested by the community » Fixed

Committed fe6a9ab and pushed to main. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.