Problem/Motivation

Changes have been made to the Gitlab CI template configuration.

- Migrate Plus: https://git.drupalcode.org/project/migrate_plus/-/blob/d7d3c692a7d7f885d...
- Gitlab CI templates: https://git.drupalcode.org/project/gitlab_templates/-/blob/main/gitlab-c...

Steps to reproduce

Noticed while investigating issues in CI. No functional change, but means we get a shorter, more up to date set of docs (and correct URLs) in this module's configuration.

Proposed resolution

Update the file, preserving existing changes/customisation.

Remaining tasks

- Make PR
- Review

User interface changes

API changes

Data model changes

Issue fork migrate_plus-3565782

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

xurizaemon created an issue. See original summary.

xurizaemon opened merge request !148

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented
Status: Active » Needs review

CI failure is due to #3565496: pipeline failure - composer (previous minor) / #3564269: Composer 2.9 blocks dependencies which have security advisories, not this PR.

Passing test run (with "previous minor" not enabled) can be seen at https://git.drupalcode.org/project/migrate_plus/-/merge_requests/148/pip...

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs review » Closed (won't fix)

Those issues should be resolved fairly quickly, so I'm not going to move forward here unless those stall out for some reason. If they do stall, we can reopen and consider doing these changes.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented
Priority: Normal » Minor
Status: Closed (won't fix) » Needs review

Hi Lucas,

Sorry if this was unclear!

This MR is not trying to solve that CI issue - the only change here is updating the template inline docs to match what's upstream.

The current template contains links & docs which have been superceded or deprecated.

It's not a big change, and from the MR you can see there's no functional change (only changes to lines starting with a comment).

I will put this back to "needs review", but there's no urgency on this, since it's only DX/docs really :)

  • heddn committed e48da88e on 6.0.x authored by xurizaemon 
    chore: #3565782 Update .gitlab-ci.yml configuration from Gitlab...
heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs review » Fixed

Thanks for that explanation.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.