Problem/Motivation
The module uses Drupal\Core\ProxyClass\Routing\RouteBuilder in three form classes, which is a deprecated proxy class. While the 3.x branch has D11 support declared and the ConfigFormBase constructor fix is in place, this deprecated usage should be replaced with the proper interface for full compatibility and to avoid deprecation warnings.
Affected files:
- src/Form/AccessSettingsPageForm.php
- src/Form/CommonSettingsPageForm.php
- src/Form/CreateRegistrationPageForm.php
Steps to reproduce
1. Install Drupal 11 with deprecation error reporting enabled
2. Enable multiple_registration module
3. Deprecation notices appear for ProxyClass\Routing\RouteBuilder usage
Proposed resolution
Replace Drupal\Core\ProxyClass\Routing\RouteBuilder with Drupal\Core\Routing\RouteBuilderInterface in all three form classes (import statements, docblocks, and constructor type hints).
Remaining tasks
- Review and test
- Merge
User interface changes
none
API changes
none
Data model changes
none
Issue fork multiple_registration-3565293
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
oivanov commentedthe MR is ready for review
Comment #4
dhruv.mittal commentedReviewing it
Comment #5
dhruv.mittal commentedHello @oivanov
Thank you for you contribution.
I can confirm that the use of Drupal\Core\ProxyClass\Routing\RouteBuilder is deprecated.
And also reviewed the changes that you have made and those looks good to me so moving it to RTBC
Thanks!!
Comment #6
ysamoylenko commentedThanks to all people for the contribution.
The changes have been merged.