CommentFileSizeAuthor
#6 page_manager_ui-d11-support.patch673 bytesdhavalpanchal
#5 page_manager_ui-d11-support.patch775 bytesdhavalpanchal
#4 page_manager_ui-d11-support.patch862 bytesdhavalpanchal

Issue fork page_manager-3565159

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mably created an issue. See original summary.

mably opened merge request !47

mably’s picture

mably commented
Status: Active » Needs review
dhavalpanchal’s picture

dhavalpanchal commented
Issue summary: View changes
StatusFileSize
new page_manager_ui-d11-support.patch862 bytes

We can use these patch for D11.3.2.

dhavalpanchal’s picture

dhavalpanchal commented
StatusFileSize
new page_manager_ui-d11-support.patch775 bytes
dhavalpanchal’s picture

dhavalpanchal commented
StatusFileSize
new page_manager_ui-d11-support.patch673 bytes

joelpittet made their first commit to this issue’s fork.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Fixed

Closing as fixed.

This code was originally added as a paired workaround for the Layout Builder and Seven theme and fixed in #3005403: Cannot delete or edit a block that is placed in a section of the layout_builder. It only applies to layout_builder_block contextual links, so it was never meant as general admin theme support for Page Manager routes.

Now that #3005403: Cannot delete or edit a block that is placed in a section of the layout_builder is resolved, there is no Page Manager-specific behaviour left here to maintain. The additional guard around seven_preprocess_block() was effectively just preserving that outdated compatibility layer.

Given that, removing was the route taken. LMK if you run into any side-effects of this change.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Version: 8.x-4.0-rc3 » 8.x-4.x-dev

  • joelpittet committed 1fb6b7ad on 8.x-4.x authored by mably 
    fix: #3565159 Call to undefined function seven_preprocess_block()

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.