Problem/Motivation

When running Google Analytics Reports on PHP 8.4, deprecation warnings are triggered due to implicitly nullable parameters that are not explicitly declared as nullable.

PHP 8.4 requires parameters with a default value of NULL to use explicit nullable type hints (e.g. ?Type). Without this, PHP raises deprecation notices during execution.

These warnings affect code quality and can break strict CI pipelines that treat deprecations as failures.

Proposed resolution

Update method signatures across the module to explicitly declare nullable parameters using nullable type hints.

Remaining tasks

  • ✅ File an issue
  • ✅ Addition/Change/Update/Fix
  • ✅ Testing to ensure no regression
  • ➖ Automated unit testing coverage
  • ➖ Automated functional testing coverage
  • ➖ UX/UI designer responsibilities
  • ➖ Readability
  • ➖ Accessibility
  • ➖ Performance
  • ➖ Security
  • ➖ Documentation
  • ✅ Code review by maintainers
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Release notes snippet
  • ✅ Release google_analytics_reports-4.0.1, google_analytics_reports-3.3.0

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • fix: #3564964 PHP 8.4 compatibility - implicit nullable parameter deprecations in Google Analytics Reports

Comments

rajab natshah created an issue. See original summary.

  • rajab natshah committed 4d2aab32 on 4.0.x
    fix: #3564964 PHP 8.4 compatibility - implicit nullable parameter...

  • rajab natshah committed 92cafba6 on 8.x-3.x
    fix: #3564964 PHP 8.4 compatibility - implicit nullable parameter...
rajab natshah’s picture

rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.