Problem/Motivation

When using responsive images, responsive images load image styles multiple times, and also get the image effects multiple times which sorts all of the image effects multiple times etc. The image style config entity itself tries to cache the plugin sorting, but that doesn't work if it's not static cached itself.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#7 3564923-nr-bot_cjk2yyrz.txt91 bytesneeds-review-queue-bot
#3 Screenshot from 2025-12-27 16-52-28.png179.66 KBcatch
#3 Screenshot from 2025-12-27 16-52-33.png183.46 KBcatch

Issue fork drupal-3564923

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

catch opened merge request !14176

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs work
StatusFileSize
new Screenshot from 2025-12-27 16-52-33.png183.46 KB
new Screenshot from 2025-12-27 16-52-28.png179.66 KB

Adding before/after xhprof screenshots. Saves approximately 13,000 function calls on the Umami front page with a cold cache (out of 1.6 million in total so not a lot in the scheme of things, but not nothing).

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Seems straight forward enough.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Reviewed & tested by the community » Needs work
StatusFileSize
new 3564923-nr-bot_cjk2yyrz.txt91 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Reviewed & tested by the community

Rebased.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work

Needs a reroll as there are conflicts.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Reviewed & tested by the community

Rebased.

catch’s picture

catch
he/him
Primary language English
commented

Re-rebased.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 4b6e60ce088 to main and 2599d739104 to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • alexpott committed 2599d739 on 11.x 
    perf: #3564923 Static cache image style config entities

By: catch
(...

  • alexpott committed 4b6e60ce on main 
    perf: #3564923 Static cache image style config entities

By: catch

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.