I noticed today that we use a different widget for the order currency vs. the current currency conditions. For the order currency, we use our Commerce entity select widget, which converts to an autocomplete textfield when more than X currencies are enabled. For the newer condition, we just use the checkboxes widget.

On the one hand, the entity select widget is nice for avoiding massive, unwieldy forms. However, in this context, there are relatively few sites in the world that are going to have every currency enabled, while the default threshold for reverting to an autocomplete is relatively low for some merchants. Additionally, the full checkboxes list is not always going to be visible - only when the conditions are being edited.

My proposal is to standardize the order currency condition to use checkboxes, but we don't have consensus, we should at least revise the current currency condition to use the same entity select widget.

Issue fork commerce-3564199

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

rszrama created an issue. See original summary.

khiminrm made their first commit to this issue’s fork.

khiminrm’s picture

Status: Active » Needs review

jsacksick made their first commit to this issue’s fork.

  • jsacksick committed 87b900eb on 3.x authored by khiminrm
    feat: #3564199 Always use checkboxes for the order currency condition...
jsacksick’s picture

Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.