Problem/Motivation

The config/install directories of some modules contain some config with unmet dependencies.

Steps to reproduce

drush si -y minimal
drush en -y l10n_server

-> Configuration objects provided by l10n_server have unmet dependencies: views.view.l10n_server_files (views)

I assume that this is the case in more than just one module.

Proposed resolution

Two options, to be decided per config:

  1. Move the config to config/optional.
    This is only an option if nothing else in the module depends on that configuration.
  2. Require views (or other) module in the *.info.yml file of the respective module.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork l10n_server-3564180

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

donquixote created an issue. See original summary.

donquixote opened merge request !110

donquixote’s picture

donquixote commented
Status: Active » Needs review
donquixote’s picture

donquixote commented

I am now fixing a lot more stuff in this branch.
Because we can!

donquixote’s picture

donquixote commented

I refactored the integrity test to use iterators.
It's a bit funky but imo it is the way to go.

donquixote’s picture

donquixote commented

I pushed more changes which split the ModuleIntegrityTest.
Now we have a separate test for views, to detect broken handlers.

Maybe we should split things up, and only do the first step here which is about module install.

donquixote’s picture

donquixote commented

I had a look at L10nPackagerDownloadForm which uses that permission.
It seems that form does not really do anything meaningful. It seems like stub code copied from a "how to create a Drupal form" tutorial.

I see that more work is done here, #3338987: Finalize l10n_packager route /downloads..
So maybe we should handle that first.

fmb made their first commit to this issue’s fork.

  • fmb committed 1ad484ad on 3.0.x 
    Revert "Issue #3564180: Fix table name for group content fields in '...

  • fmb committed c13b2e6a on 3.0.x authored by donquixote 
    Issue #3564180: Fix table name for group content fields in '...

  • fmb committed 0ed004a0 on 3.0.x authored by donquixote 
    Issue #3564180: Add missing module dependencies.

  • fmb committed 818e7443 on 3.0.x authored by donquixote 
    Issue #3564180: Let l10n_server depend on views, to make config objects...

  • fmb committed d127a965 on 3.0.x authored by donquixote 
    Issue #3564180: Add migrate_tools to require-dev, it is needed for...

  • fmb committed bdeaff07 on 3.0.x authored by donquixote 
    Issue #3564180: Add sort-packages true in composer.json.

  • fmb committed 37093f70 on 3.0.x authored by donquixote 
    Issue #3564180: Configure which composer plugins should be enabled, to...
fmb’s picture

fmb commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.