Problem/Motivation

When you format as plain text and select the option to only view current day there is an issue with the exception days label format. You can select a Date format for exception days, but it passes the formatter ID to the formatting and not the actual pattern from that formatter.

Issue lies in the OfficeHoursExceptionsItem class in the label function.
$settings['day_format'] = $settings['exceptions']['date_format'] is passed to the label formatter.
But that is just the id of the date format.

Comments

yorder.be created an issue. See original summary.

johnv’s picture

johnv
Primary language Dutch
commented

I see the latest version is from April 2025.
In the mean time several commits are added. It is already some time ago, But I vaguely remember a change in this. I cannot find hyou line of code in my dev version.
Please test dev version and report back.
I will create a new version afterwards.

OfficeHoursDateHelper::format() is used. OfficeHoursExceptionItem::label() is not used in the formatter anymore.

johnv’s picture

johnv
Primary language Dutch
commented
Status: Active » Closed (outdated)

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.