Problem/Motivation

Currently in 1.x branch, tests are disabled for Drupal 11.x

Steps to reproduce

Proposed resolution

Run tests for Drupal 11.x.
Make them pass.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork l10n_server-3562996

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

donquixote created an issue. See original summary.

donquixote opened merge request !102

donquixote’s picture

donquixote commented
Status: Active » Needs review

  • donquixote committed 74a6eb51 on 3.0.x 
    Issue #3562996: Remove the 'default_argument_skip_url' from views config...

  • donquixote committed 237cc0dc on 3.0.x 
    Issue #3562996: Test in current major (Drupal 11).

  • donquixote committed a8ff55b0 on 3.0.x 
    Issue #3562996: Remove duplicate line for 'OPT_IN_TEST_PREVIOUS_MAJOR'.
fmb’s picture

fmb commented
Status: Needs review » Needs work

Thanks!

Tests now "pass with warnings", so I guess this issue still "needs work", unless you consider these warnings must be addressed elsewhere?

donquixote’s picture

donquixote commented

Hi,
the main goal was to make tests pass equally in D11 and D10.

Regarding the "II", I find the following when I run with `--display-all-issues`:

  • "Metadata" (annotations) in doc comments are deprecated, we should use attributes.
    (We should not change this as long as we support Drupal 10)
  • 2 incomplete tests. 
There were 2 incomplete tests:

1) Drupal\Tests\l10n_migrate\Kernel\MigrateL10nServerGroupTest::testRowsComplete
/var/www/html/l10n_migrate/tests/src/Kernel/MigrateL10nServerGroupTest.php:114

2) Drupal\Tests\l10n_migrate\Kernel\MigrateL10nServerGroupTest::testDatasetsComplete
/var/www/html/l10n_migrate/tests/src/Kernel/MigrateL10nServerGroupTest.php:121

This is literally in the test itself:

  /**
   * Tests migration for completeness.
   */
  public function testRowsComplete(): void {
    $this->markTestIncomplete();
  }

  /**
   * Tests migration for completeness.
   */
  public function testDatasetsComplete(): void {
    $this->markTestIncomplete();
  }

I think we should fix this in a separate issue.

fmb’s picture

fmb commented
Status: Needs work » Fixed

All right, I will let you open these issues, then.

For the record, I do not plan to keep supporting Drupal 10. I do not think it makes much sense for this project since we do not need to care about compatibility with existing installations.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.