Reviewed & tested by the community
Project:
Commerce Stripe
Version:
2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
9 Dec 2025 at 16:00 UTC
Updated:
10 Apr 2026 at 19:21 UTC
Jump to comment: Most recent
Comments
Comment #3
milanbombschliip commentedComment #4
alanhdev commentedLooks like a duplicate of https://www.drupal.org/project/commerce_stripe/issues/3539260. Happy with either of these MRs as a fix.
Comment #5
milanbombschliip commentedComment #7
anybodyThanks @alanhdev yes looks like a duplicate. I'd say the approach taken here is a bit cleaner, but maintainers should decide which way they prefer. Both fix the issue, but the other one more or less hides it...
Comment #8
rhovlandThis one is the correct approach as it improves type safety of the code. The @var doc comment was probably suppressing a PHPStan error about this too.
Comment #9
anybodyThanks @rhovland would you mind setting this RTBC then, if you tried?
Comment #10
mradcliffe@unqunq mentioned that the MR resolved the issue.
I reviewed the code change, and this makes sense based on the return type so I will change the status to RTBC.